From nobody Sat Aug 8 08:08:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hHDCs5v5Tz6nG8R; Sat, 08 Aug 2026 08:08:09 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hHDCs4bxbz3x63; Sat, 08 Aug 2026 08:08:09 +0000 (UTC) (envelope-from bms@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786176489; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b6ISvcGO7w8yFLBln/cjo6KQlZJTEjqI1WYXgjaZDjQ=; b=uI7Xm26/P7jnlNvIKo8e5Ctk1HqmlRJEXQo597EGUA0uiT/NwCM2kk0e2mjn6t2y920IS9 FEfmRZgVzmH8qSoaCYn8JH6Dtk8I3gmTUUdjDZhlquBqMNEqVHtHqYP9SFlE92JIiPFjZT kI93NcLFsclry0WAgqxR8typLSnntoL2d+g7To1YSehvVVx0hDQdz2SNY80QQJiY4/rZB/ zE5FHSqFscH1uFQtMW1nVQdrNZ8UVGbJzAwHs/32AG5whmOF7ITNhX6MyIPzxdL74I7Vi5 SSYNW+4v+spfjPXMfhG8+ZxlJPASk8roqSdTK/olDRrkwnxZGW+RNckkIFiH5Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786176489; a=rsa-sha256; cv=none; b=RmDNTQCsT+4ESZUXehrbrqr8gjJF109IfGbBojI1tJt5mrIOMFJVHsjEgTel6WbR1jbmMg H37lh/iBdgTkrrL0D3bAX9fWIb1nMdjbsz3OVzdQ7LqLz7Rab7zD0ee+n8GvgL7PUTVHra S1NUh35Zg7xR56sRGz/9wtp/8ln92YII4boMPO9GDKCBX16nFe3oGmNEGcKD1EkBnyPggP 9tnFkpytMZynGj8suJl23/rIgk7d94FS7FereqWjo78FKvv6zwp6plmgmf+C20uZ42Cdkm ITod+UyKg2DmaMpr5ieVcjzOuG1NY/jzlwC5gjBB85+LgeUOOMBzFXAZF/wRvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786176489; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b6ISvcGO7w8yFLBln/cjo6KQlZJTEjqI1WYXgjaZDjQ=; b=yOJFZug88EvB/xGicxerUQplYQeBRpHqHA82wfwbLAKmaaJAdyRW4sC1R/MtGiQh6blp9s jAG6yveza59jTjpuQLuC0BRPjD7auTzm4w4PFKVQ0iwNQ0TcXhCXZdv9lqbD3p91ql53yx r8Yewk6u84pVaDsgHY+2gLnN1R6Rx8S1uVR3x7+sr6N8GhINKWFUJm/dJDvFYdSH6CzNPK YR4EcqMndzzPEmUqFxbVAiGoRxlk2QOPpdhBhuH86MrQnOyP1TKAnJUzyHqFT3dtrAgyoZ E1zsxZASYHpZCAzwLoJcl7OLjAkGCK6gk3N65CggHCsSPBD1vLR1I72A8sseXA== Received: from [IPV6:2a03:1b20:7:f011::d401] (unknown [IPv6:2a03:1b20:7:f011::d401]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bms) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hHDCr4vh5z12lT; Sat, 08 Aug 2026 08:08:08 +0000 (UTC) (envelope-from bms@FreeBSD.org) Message-ID: <57daffd7-3a4b-40dc-80fb-945851929412@FreeBSD.org> Date: Sat, 8 Aug 2026 09:08:04 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8f6561e8adbd - stable/15 - ixv: fix multicast address enumeration To: Kevin Bowling , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org References: <6a767a79.3dae1.16b03095@gitrepo.freebsd.org> Content-Language: en-GB From: Bruce Simpson Reply-To: bms@FreeBSD.org Autocrypt: addr=bms@FreeBSD.org; keydata= xjMEaVGCmhYJKwYBBAHaRw8BAQdAsg8i6xStZxNET5weeGhqk+jxmUMXkQywo5QzbA0YBIDN H0JydWNlIFNpbXBzb24gPGJtc0BGcmVlQlNELm9yZz7CmQQTFgoAQRYhBMK4uc6m7LT7aiKJ rI74DHQDQU6tBQJpjQkiAhsDBQkFpIUmBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJ EI74DHQDQU6ttBYBANSEXAU8hm8moOUmA3PV4h1LfHJ96qJuQFbjIGmiXm76AP9tDCoS+a+g s6ooWwIo4N99hyGvaUf7zjXrdcKbE/u3Bc44BGlRgpoSCisGAQQBl1UBBQEBB0C+jg0d6ULD AzAejZnFRX8BjkqLrw7VXBa7xlb1wWJmYAMBCAfCfgQYFgoAJhYhBMK4uc6m7LT7aiKJrI74 DHQDQU6tBQJpUYKaAhsMBQkFpIUmAAoJEI74DHQDQU6tq+gBAIy+EZG092O+UbPY3edIhj0a GAZdU0WMTAhFzvAyBZZ1AP9uNJlhSz4+/RDncVN2h6st0RkKddJkbEJa1rZKh9R6DQ== Organization: The FreeBSD Project In-Reply-To: <6a767a79.3dae1.16b03095@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Somewhat related: I'm concerned that ifmcstat(8) may not be reporting AF_LINK memberships in all cases, only the ones which were plumbed there by an upper layer (AF_INET, AF_INET6). I noticed this when preparing "add that which was never ratified" for IPv6 sockets. It's a potential issue for LLDP, Carrier Ethernet and IS-IS bring-up. Has anyone else observed this? Is anyone else actively using it, or using FreeBSD for these control plane protocols? It may be a "bms@ ends up having to fix it again" issue because I merged ifmcstat(8) from NetBSD originally. #tragedyofthecommons On 08/08/2026 01:38, Kevin Bowling wrote: > The branch stable/15 has been updated by kbowling: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8f6561e8adbd07f52278b5a404c72d5c9643b471 > > commit 8f6561e8adbd07f52278b5a404c72d5c9643b471 > Author: Kevin Bowling > AuthorDate: 2026-07-28 11:06:23 +0000 > Commit: Kevin Bowling > CommitDate: 2026-08-08 00:34:24 +0000 > > ixv: fix multicast address enumeration > > if_foreach_llmaddr() adds each callback return value to its running > count. Returning the incremented count made the address indices grow > as 0, 1, 3, 7, and so on, eventually writing beyond the multicast > address array. > > Return one address per callback and stop copying when the array is > full, matching the ixv-1.6.12 driver. > > Fixes: ff06a8dbb677 ("Mechanically convert ixgbe(4) to IfAPI") > > (cherry picked from commit 6020de5ad154d54c8b9a838f28612c2182330c67) > --- > sys/dev/ixgbe/if_ixv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c > index 8a1c1aae041d..24e6fa714a7b 100644 > --- a/sys/dev/ixgbe/if_ixv.c > +++ b/sys/dev/ixgbe/if_ixv.c > @@ -842,11 +842,14 @@ ixv_negotiate_api(struct ixgbe_softc *sc) > static u_int > ixv_if_multi_set_cb(void *cb_arg, struct sockaddr_dl *addr, u_int cnt) > { > + if (cnt >= MAX_NUM_MULTICAST_ADDRESSES) > + return (0); > + > bcopy(LLADDR(addr), > &((u8 *)cb_arg)[cnt * IXGBE_ETH_LENGTH_OF_ADDRESS], > IXGBE_ETH_LENGTH_OF_ADDRESS); > > - return (++cnt); > + return (1); > } > > /************************************************************************ > @@ -1982,4 +1985,3 @@ ixv_init_device_features(struct ixgbe_softc *sc) > if (sc->feat_cap & IXGBE_FEATURE_NEEDS_CTXD) > sc->feat_en |= IXGBE_FEATURE_NEEDS_CTXD; > } /* ixv_init_device_features */ > - >