From owner-freebsd-ports@FreeBSD.ORG  Tue Jan 18 11:49:58 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 07D6516A4FE
	for <freebsd-ports@freebsd.org>; Tue, 18 Jan 2005 11:49:58 +0000 (GMT)
Received: from voodoo.oberon.net (voodoo.oberon.net [212.118.165.100])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7E19643D31
	for <freebsd-ports@freebsd.org>; Tue, 18 Jan 2005 11:49:57 +0000 (GMT)
	(envelope-from krion@voodoo.oberon.net)
Received: from krion by voodoo.oberon.net with local (Exim 4.43 (FreeBSD))
	id 1CqrrU-000Bn9-2J; Tue, 18 Jan 2005 12:49:28 +0100
Date: Tue, 18 Jan 2005 12:49:28 +0100
From: Kirill Ponomarew <krion@voodoo.oberon.net>
To: Jeremie Le Hen <jeremie@le-hen.org>
Message-ID: <20050118114928.GB44541@voodoo.oberon.net>
References: <20050118085557.GP36629@obiwan.tataz.chchile.org>
	<41ECD481.4020308@xbsd.org> <20050118103850.GQ36629@obiwan.tataz.chchile.org>
	<20050118114344.GR36629@obiwan.tataz.chchile.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050118114344.GR36629@obiwan.tataz.chchile.org>
X-NCC-Regid: de.oberon
X-NIC-HDL: KP869-RIPE
cc: riggs@rrr.de
cc: freebsd-ports@freebsd.org
cc: Florent Thoumie <flz@xbsd.org>
Subject: Re: WITHOUT_X11 knob for mplayer
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2005 11:49:58 -0000

On Tue, Jan 18, 2005 at 12:43:44PM +0100, Jeremie Le Hen wrote:
> I had a look in the porter's handbook.  Here are the drawbacks I found
> about using USE_IMAKE knob:
> 
> %%%
>   Define USE_XLIB=yes if your port requires the X Window System to be
>   installed (it is implied by USE_IMAKE).
> 
>   USE_IMAKE	The port uses imake. Implies USE_X_PREFIX.
> %%%
> 
> Obviously, this would make my patch completely useless :-).
> 
> Whereas it can be interpreted as an inconsistency in the mplayer build
> system (usage of imake(1) even if not linked with X11 libs), my opinion
> is that this is a ports system weakness for this particular situation.
> Nevertheless I'm convinced there are good reasons to have the USE_IMAKE
> knob implying the USE_XLIB one.
> 
> I would like to circomvent the use of USE_IMAKE here.  Florent stated
> that the imake version depends on X_WINDOWS_SYSTEM but my BUILD_DEPENDS
> is only used when the WITHOUT_X11 knob is on.  Thus I think we could
> use an arbitrary version of imake (say imake-6).  This won't be very
> fair for those still running XFree86 as X_WINDOWS_SYSTEM and building
> mplayer WITHOUT_X11, but there are obviously a very few.
> 
> Do you all agree with me ?

Did you try ?

BUILD_DEPENDS=   imake:${X_IMAKE_PORT}

-Kirill