From nobody Sat May 2 18:08:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7G9k3qzyz6bC2W for ; Sat, 02 May 2026 18:08:26 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7G9j5gYYz3mGr for ; Sat, 02 May 2026 18:08:25 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=PC0tISwy; dmarc=pass (policy=none) header.from=hardenedbsd.org; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::335 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7dbccf6a23dso2625884a34.2 for ; Sat, 02 May 2026 11:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1777745303; x=1778350103; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/gpa2kgCItpKHzZccngjQ2jXez1w0pM2Kicmknp4xng=; b=PC0tISwyqe6bpR6Odzb71+d+7SmESKSyedrJDSgIjmY8dCocWn+suvg5KLb9YvB/+6 C95OJKpzUgweSYoFwXadEZaeRCNq/4tiLRBJ5qbIoMqKCDfjCaU2tSp7h83iSfLJjavm 8m7K5d7UNiJ93japxl4aDIN21DrEXEO8lT29xdw9DjOs/zUIGDhKBYV1nGkXEj3Gi0ZT oobwfBLHhviONpenHcjgSw+7p1RUwhnaqEi6jUGnzMZVda2NqIiPe8WRNgTnjlujr31D vS44jg6rU+xAUV0M98bfT9zH07976Elkl+DsI/Er8Y2knDTAOPz9McKem6nfJifgcJQ+ EW+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777745303; x=1778350103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/gpa2kgCItpKHzZccngjQ2jXez1w0pM2Kicmknp4xng=; b=h01eiJd3LNVogvQgfNZ/FdcZr3WZfG/Dvz+NGEySZ/yjpYoCgxEpR9PNk1FqkbLjcJ hzg3gTvNv2UosPh4KVubR6bvjJ1y5dWEoNGmn9qoAkCxpGII79FNDYNc4WkLe3fPZsFN f5o76X2iOYlMTeKw0Qq8NTAnxevD776+5ENmM39iUOOOVwFv+N3LJ3jmZpAJyMGfCeOn qUzKP3E17CLpgQNW+ce5Fa91XJTyW2teP8MSH3Bkx/M8UH7n2O3X/DrOXJZzbjZ6UR9k aKx/YFYmjjDiGEdI1jbWLWJ7rWo1SoMwE7xrEN//gvSU8S4HpM0HDdFSBycd3R6ZaPSH ZpXQ== X-Forwarded-Encrypted: i=1; AFNElJ/svhMzbQ6p6EEjtehV4Ye7xdgpzz8utxZMIIU8fUYLHrO/a3XGGd9Z9Jl7KOIR8jzlrlv0v2zV+HFJX6T616kUhWBf@freebsd.org X-Gm-Message-State: AOJu0YzJkJ32+cGrisl6ihJcrgPhZx41DNDEMmCQG4W1og7nTt0iByzK 3/ZoToU5YnVu/feumjYfeK5il9vCA6R+hoES1cx5sWIFznO6pqbsvrLgFfpmhbNDDwM= X-Gm-Gg: AeBDietGBxK185wNb5O01C2eeK/inArWN2hmUZUG/iusEN+MZupQln31SGu7PHixn+J VYzUOukCLj2M8ElJHuKTnit1l4l2Q0/5+/JYr1vitM6yuwAyAj981a5bVRAknBOc91gwC8ecX0W sDtV6GK/rFvCgxfyS6nMtZ+UDXfqQUdftRZEOrp5fzrfskctG3wE0ogQ8s2W+Kz/5H/pBvv7L7W HlCmQQi/GASLACdjP5dLMQOsE8wKTza0rx3xHGD4MiCVKU82ki/+YwDADpnfS2tPIUAgiC8OTMF a1bxi9yYc5HbnR8MsEDY1bz3HDSY0ibc7TM1VHWfZlUWoBTEh9a3F2G6EZnPh6WpfQeomAPP7Ri II7Q1RwUEBkrwm9VBY3QQltOVHBkjPMEcGyKoDZMMDqylaSg4WoBlJ722HLuSuLKa2E3xKrBGub lo0QHBldCFbBpc2JwypwT8nN01jlHYLw== X-Received: by 2002:a05:6820:f030:b0:696:1a85:5873 with SMTP id 006d021491bc7-69697c40786mr1893906eaf.31.1777745303085; Sat, 02 May 2026 11:08:23 -0700 (PDT) Received: from mutt-hbsd ([97.112.164.127]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69689479359sm3568773eaf.7.2026.05.02.11.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 May 2026 11:08:22 -0700 (PDT) Date: Sat, 2 May 2026 18:08:21 +0000 From: Shawn Webb To: Lexi Winter Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: d1c176fedfc9 - main - packages: Make create-sets.sh more robust Message-ID: X-Operating-System: FreeBSD mutt-hbsd 15.0-STABLE-HBSD FreeBSD 15.0-STABLE-HBSD HARDENEDBSD amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <69f10fa0.34907.7c21574e@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hlpxyxcwsm7g5w4r" Content-Disposition: inline In-Reply-To: <69f10fa0.34907.7c21574e@gitrepo.freebsd.org> X-Spamd-Result: default: False [-5.60 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[hardenedbsd.org,none]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::335:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[4]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; DKIM_TRACE(0.00)[hardenedbsd.org:+] X-Spamd-Bar: ----- X-Rspamd-Queue-Id: 4g7G9j5gYYz3mGr --hlpxyxcwsm7g5w4r Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: d1c176fedfc9 - main - packages: Make create-sets.sh more robust MIME-Version: 1.0 On Tue, Apr 28, 2026 at 07:50:56PM +0000, Lexi Winter wrote: > The branch main has been updated by ivy: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd1c176fedfc99d61c1dc8037ab= 549bec48c17bea >=20 > commit d1c176fedfc99d61c1dc8037ab549bec48c17bea > Author: Lexi Winter > AuthorDate: 2026-04-28 19:39:14 +0000 > Commit: Lexi Winter > CommitDate: 2026-04-28 19:50:42 +0000 >=20 > packages: Make create-sets.sh more robust > =20 > Use ${PKG_CMD} rather than bare 'pkg' to fix the build when pkg is > not in the tools path. Provide a default in case it's not set for > some reason (e.g., running the script by hand). > =20 > Since set -- $(...) does not trigger an exit from set -e if the > command fails, this failure was silent and resulted in sets not > being built correctly if we failed to run pkg. Use a temporary > variable, which does trigger set -e, to fail correctly. > =20 > MFC after: 2 weeks > Reviewed by: sjg > Sponsored by: https://www.patreon.com/bsdivy > Differential Revision: https://reviews.freebsd.org/D56676 > --- > release/packages/create-sets.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/release/packages/create-sets.sh b/release/packages/create-se= ts.sh > index 46dfd543619c..3dfd8f1a3388 100755 > --- a/release/packages/create-sets.sh > +++ b/release/packages/create-sets.sh > @@ -26,6 +26,8 @@ if [ $# -lt 3 ]; then > exit 1 > fi > =20 > +: ${PKG_CMD:=3D"pkg"} > + > srcdir=3D"$1"; shift > wstagedir=3D"$1"; shift > repodir=3D"$1"; shift > @@ -43,7 +45,8 @@ for pkg in "$repodir"/*.pkg; do > # packages. > { echo "$pkg" | grep -q '-'; } || continue > =20 > - set -- $(pkg query -F "$pkg" '%At %n %Av' | grep '^set ') > + _tmp=3D"$(${PKG_CMD} query -F "$pkg" '%At %n %Av' | grep '^set ')" > + set -- $_tmp > pkgname=3D"$2" > sets=3D"$(echo "$3" | tr , ' ')" > for set in $sets; do >=20 After this commit, the create-sets.sh script exits with an error code, but no error message. I'm not entirely sure what's going wrong for me. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --hlpxyxcwsm7g5w4r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmn2PYsACgkQ/y5nonf4 4frmQg//eYfcnejKFg8NbHvwS77x+6AuciQ89xA6medXHbsmcsEQnKfkRNhBAVM+ 0ILazh0EHu3hA5vyJe7+hIjL041pFPLMc4O2V6+lwQ35xeU6XUUTgfnm38irebUB aZgF+Sq9a5nYZWvoq3RYd/4E43BJnEWvjXw/HbVdFU7VKxY8PNT6EmwRgJPlwOEe 50phboydFbZjdxOh6LkXHxvzt53ovw5bsoRgvFUj6yZqGG6KNYoOAs6PgzwW8jBC tMdSrkFbiqtPxwtlf1ZGOJXu76GgBdry0Y902mx0ufiE1MrXA0p8s4xLelqKj6E+ CR2R8Pmz+5iDx2ezJo/ZuzBnb9VCvFhdmE3M7NYTbAKLVg7cOf66wA52rfMOM8Aa RE2+vqDx9qi5B0hxcXw+6J8mYU/sP33EbtTmnUqyBiNVDQT8dqjd2INt/haesQxz k20B6K1wJh1tWqDqUSy/JHhOBHDkVUleafivvLTmTgFigbz9go81DMwviYK/3IyK AO562wwgpSLFRhj5/BC7NXoaFB/UWCR8OGOn6i89lrl3SpUsZh5M13Y2gfr2bw0a 0rnJh/fo9oPqe9SumMBtu8U8BndHhm9pNcJFQI/QD6BpP0Bn/PSwLQs+W0AIAVou SGPqwFeLS4ppfO5BJQovxoNfESovqecsBpvNaTAaAP/RGu5lWjA= =SwUf -----END PGP SIGNATURE----- --hlpxyxcwsm7g5w4r--