Date: Sat, 21 May 2016 11:18:03 -0600 From: Ian Lepore <ian@freebsd.org> To: Joerg Sonnenberger <joerg@bec.de> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "freebsd-arm@FreeBSD.org" <freebsd-arm@FreeBSD.org> Subject: Re: svn commit: r300375 - head/sys/arm/include Message-ID: <1463851083.1180.381.camel@freebsd.org> In-Reply-To: <20160521170156.GA28128@britannica.bec.de> References: <201605211652.u4LGqcnw013156@repo.freebsd.org> <20160521170156.GA28128@britannica.bec.de>
next in thread | previous in thread | raw e-mail | index | archive | help
freebsd-arm@ added to cc list. On Sat, 2016-05-21 at 19:01 +0200, Joerg Sonnenberger wrote: > On Sat, May 21, 2016 at 04:52:38PM +0000, Ian Lepore wrote: > > Author: ian > > Date: Sat May 21 16:52:38 2016 > > New Revision: 300375 > > URL: https://svnweb.freebsd.org/changeset/base/300375 > > > > Log: > > Adjust _ALIGNBYTES to the proper value for arm and armv6 arches. Modern > > compilers can emit arm instructions that require 8-byte alignment. The > > alignment-sensitive instructions were added in armv5, which has to be > > supported by our combined v4/v5 kernels, so the value is set uncoditionally > > for all arm architecture versions. > > Doesn't this change effectively break the ABI of CMSG? > > Joerg > Yep, it sure enough potentially does so. Although I didn't find any actual breakage in testing base-system stuff, it potentially could cause problems for some ports. But ports and packages and everybody's armv6 kernel and world already need recompiling because of the recent soft/hardfloat change, so if this problem was ever going to get corrected, now is the time to do it (especially before freebsd 11 is released, and before arm moves to being a tier-1 platform with the strong ABI guarantees that come with that). I think this week before the code freeze is going to be a bit of rough sailing in the arm waters. It really is our last chance to make a few disruptive changes; if we don't get them done soon, we live with our mistakes forever after. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1463851083.1180.381.camel>