From owner-dev-commits-src-all@freebsd.org Tue Jan 26 03:32:25 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBBE04FD8BF; Tue, 26 Jan 2021 03:32:25 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DPsk04YDzz4f28; Tue, 26 Jan 2021 03:32:24 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id 4F5YlgANfnRGt4F5aljwi6; Mon, 25 Jan 2021 20:32:22 -0700 X-Authority-Analysis: v=2.4 cv=cagXElPM c=1 sm=1 tr=0 ts=600f8d46 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=EmqxpYm9HcoA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=kIYH8ehIrI99oz5jYvoA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 23458517; Mon, 25 Jan 2021 19:32:20 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 10Q3WKuW003844; Mon, 25 Jan 2021 19:32:20 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202101260332.10Q3WKuW003844@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 83edbc3cb54f - main - ipfilter: Retire pre-standard C support. In-reply-to: References: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> Comments: In-reply-to Philip Paeps message dated "Tue, 26 Jan 2021 09:52:20 +0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 25 Jan 2021 19:32:20 -0800 X-CMAE-Envelope: MS4xfM6KRjvlZYwCvB1iKRmX8nLufmikc//0urbfTDk7JbED9o9e38GysfTFs2gu4WU+Yn3A45VLls0qhL8G8jaK9kxtJW4KwE628gJYIg3FNqsU+PyUqpp/ A5muwvPKvLMY/H17VN41xlikAIUh/BxHgW0ndFv3YzggTFDQwForihm4C7nk4ohL5gcNCgYiJaMDuHKQGwWJoPGubX/vVhGl7vvk0XBcqhoJQDRBskypOtuS cO/iDVEHFr1evmAQ93lKuQuP6zHkavGiK8fmMIPfB9MnWELnB5O+HRmlEx/lP07nd7AinKB7I/rdKhCdoUSBXILFA30kxA8zu0XlpppXr78= X-Rspamd-Queue-Id: 4DPsk04YDzz4f28 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.138) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.70 / 15.00]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RECEIVED_SPAMHAUS_PBL(0.00)[70.67.229.168:received]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_LOW(-0.10)[64.59.136.138:from]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; AUTH_NA(1.00)[]; RCVD_TLS_LAST(0.00)[]; R_SPF_NA(0.00)[no SPF record]; RWL_MAILSPIKE_VERYGOOD(0.00)[64.59.136.138:from]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 03:32:25 -0000 In message , Philip Paeps writes: > On 2021-01-25 22:47:11 (+0000), Cy Schubert wrote: > > ipfilter: Retire pre-standard C support. > > > > All C compilers in 2021 support standard C and architectures that did > > not were retired long ago. Simplify by removing now redundant > > pre-standard C code. > > [...] > > > > #ifndef __P > >-# ifdef __STDC__ > > # define __P(x) x > >-# else > >-# define __P(x) () > >-# endif > >-#endif > > You could simplify even further by getting rid of the __P() convention > altogether. All our compilers support prototypes in 2021. :) Yes, it's in my queue. ANSI function definitions is in another branch. The last cleanup being style(9). -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.