From owner-freebsd-ports@FreeBSD.ORG Wed Feb 27 12:04:43 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E78F11065678 for ; Wed, 27 Feb 2008 12:04:43 +0000 (UTC) (envelope-from vsevolod@highsecure.ru) Received: from spray.anyhost.ru (spray.anyhost.ru [213.219.249.64]) by mx1.freebsd.org (Postfix) with ESMTP id B14D58FC2C for ; Wed, 27 Feb 2008 12:04:43 +0000 (UTC) (envelope-from vsevolod@highsecure.ru) Received: from [81.19.90.156] (helo=cebka-laptop) by spray.anyhost.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.67 (FreeBSD)) (envelope-from ) id 1JUKO2-000Km5-4l; Wed, 27 Feb 2008 14:23:46 +0300 Received: from localhost.localdomain ([127.0.0.1]) by cebka-laptop with esmtp (Exim 4.67) (envelope-from ) id 1JUKO1-00045p-Ro; Wed, 27 Feb 2008 14:23:45 +0300 Message-ID: <47C54841.3060601@highsecure.ru> Date: Wed, 27 Feb 2008 14:23:45 +0300 From: Vsevolod Stakhov User-Agent: Thunderbird 2.0.0.6 (X11/20071022) MIME-Version: 1.0 To: Ryan Tomayko References: <47C46645.80700@gmail.com> In-Reply-To: <47C46645.80700@gmail.com> Content-Type: multipart/mixed; boundary="------------000800060705070406080903" Cc: ports@freebsd.org, "Sergey A. Osokin" Subject: Re: nginx upstream_fair module patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2008 12:04:44 -0000 This is a multi-part message in MIME format. --------------000800060705070406080903 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Ryan Tomayko wrote: > Hello Sergey, > > There is an experimental module for nginx that adds fair upstream/proxy > balancing (note that this is a "third party" patch, not an optional > nginx module): > > http://wiki.codemongers.com/NginxHttpUpstreamFairModule > > We've modified the nginx port to include the patch and added a knob for > enabling it. I wasn't sure if this was something that's acceptable to > include in the official nginx port but I've attached a patch in case > you're interested. > > The patch should apply cleanly with: > I don't think that it is a good idea to have 3-rd party code as FreeBSD ports patches (ports patches are FreeBSD specific code). I think it would be better to have some directive for enabling extra modules for nginx and make subports for such modules, in the similar way as php ports for example. Here is a small patch. Maybe this should be better done using OPTIONS. --------------000800060705070406080903 Content-Type: text/x-patch; name="nginx-extra-modules.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="nginx-extra-modules.patch" --- nginx-devel.old/Makefile 2008-01-24 15:46:37.000000000 +0300 +++ nginx-devel/Makefile 2008-01-24 15:46:49.000000000 +0300 @@ -145,6 +145,13 @@ .include "${PORTSDIR}/Mk/bsd.openssl.mk" .endif +# Add 3-rd party modules to nginx dist +.if defined(WITH_EXTRA_MODULES) +. for extra_module in ${WITH_EXTRA_MODULES:C/:/ /g} +CONFIGURE_ARGS+=--add-module=${extra_module} +. endfor +.endif + PLIST_SUB+= NGINX_TMPDIR=${NGINX_TMPDIR} WWWOWN=${WWWOWN} WWWGRP=${WWWGRP} post-patch: --------------000800060705070406080903--