From owner-freebsd-hackers@freebsd.org Sun Sep 1 19:34:03 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BAB73E2E13; Sun, 1 Sep 2019 19:34:03 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M3LL4tgLz3F7F; Sun, 1 Sep 2019 19:34:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x632.google.com with SMTP id m9so5600902pls.8; Sun, 01 Sep 2019 12:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=l63SofxVDdd784Vg8NAJW4Os6jIUWrx1WnY+YevpVQA=; b=qt4p0mMCsPkHG9aMTQ9D1pgWW1dFa/rwZS4ddMl8lg3edjbt7Tw+XRQbNAQ060n7Y7 EnvF2yH//DQkRgNj5jG+egP89tfBQ6HX9bT3fS9HcLiSjN+W5Fz3aVtKemh2XlpWYl+b cdBgcGu6zokTbeOsjT5QfJBwZsFdSRyQ7atxVOZMgRctHCkVj8l1/gtI0oThaazWYpIq 5hoH4FqtNw1WpWDCWNCt4jMbd5O5M7/R8r8PhlJ9oXLMO+R7JUNpV0e7smEvfg/uXyyq q5MTuhWhO37Q+9WqizOzUgG1l0FRsXBF9My9yYHQQQ8Cuw+N0855VaaiGL21OUejc8U/ kQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=l63SofxVDdd784Vg8NAJW4Os6jIUWrx1WnY+YevpVQA=; b=n2BG9EKfq1YZdsanc6wlzC8rVG7JJWUJQ80eC0PmwZcMX99It097JkqDxY7TRGBvnm Bm8zg4sKbuDa+AKWy1ElrM74mG8OCt0KsKtNr/3EBJK3ySBatWSjXrJUwsUkWTOdaXdc yHYUc0Ndtudto9OLcWa3Ey9WVLO3oGjPEMtYObrVmyaZxUJ5gAb240fjFyUbG5mRTRKv 5ecc2Qxzdjyj3ioSUtn0xa4M6GS5DLp4fQWCvcwDGtkCzb/DBSKxWhm83/K5QFX7EgFS T+BBW3Di1I8+3YJ4sox9xVvuFqnaaSFVuaDYFU6VCc8IrWT/ghfnfxpOqQlO6R0O4MUf dSww== X-Gm-Message-State: APjAAAXvPuQQvWuXM0+G18vcB9mMwl0LOEDmOXPku5OZnfvcChXUXVkz VFmcu0haST3EfF5ooCtqT5U= X-Google-Smtp-Source: APXvYqzNdXi1saf7QuDNlXkLTtPiKk5QpC1hIfXhG0YspG4DaiqRLiA+yAqvBL4kVZ5GumeeneLF2Q== X-Received: by 2002:a17:902:b605:: with SMTP id b5mr26706199pls.103.1567366441112; Sun, 01 Sep 2019 12:34:01 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id ck8sm10242835pjb.25.2019.09.01.12.33.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Sep 2019 12:34:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: FCP 20190401-ci_policy: CI policy From: Enji Cooper In-Reply-To: <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> Date: Sun, 1 Sep 2019 12:33:59 -0700 Cc: Warner Losh , Ed Maste , FreeBSD Hackers , Li-Wen Hsu , fcp@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> References: <20190829114057.GZ71821@kib.kiev.ua> <20190830065534.GC71821@kib.kiev.ua> <73111.1567263258@kaos.jnpr.net> <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 46M3LL4tgLz3F7F X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qt4p0mMC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::632 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; RECEIVED_SPAMHAUS_PBL(0.00)[228.52.19.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-9.54), ipnet: 2607:f8b0::/32(-2.83), asn: 15169(-2.31), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 19:34:03 -0000 > On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky = wrote: >=20 > Hi, >=20 > If the fallouts could be better organized through some simple = guidelines, that would be more accepted I think: >=20 > 1) Don't commit stuff before going off work. Even though a change = looks innocent, it might break something and you'll need to fix it. >=20 > 2) Organize big changes going into the kernel, to ease debugging and = getting things back on track again. >=20 > 3) If your patch is risky, commit it on a Monday. Don't wait until = Friday. >=20 > Failure to follow the rules may have consequences like other senior = developers kicking in and doing temporary reverts until issues are = resolved. Agreed. There=E2=80=99s a reason why at my most former job (FB) we = generally knew better than to commit code on a Friday. It would cause = the weekend oncalls a lot of grief. Let=E2=80=99s put it this way: think of it like being oncall for code. = If you don=E2=80=99t have someone else to work with who can manage it, = would you like to be paged if something went south with your code = committed on a Friday? Cheers, -Enji=