From owner-svn-src-all@FreeBSD.ORG  Tue Dec 11 00:08:29 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id AD264DFE;
 Tue, 11 Dec 2012 00:08:29 +0000 (UTC) (envelope-from bright@mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id 614308FC08;
 Tue, 11 Dec 2012 00:08:29 +0000 (UTC)
Received: from kruse-124.4.ixsystems.com (drawbridge.ixsystems.com
 [206.40.55.65])
 by elvis.mu.org (Postfix) with ESMTPSA id 2909B1A3DCA;
 Mon, 10 Dec 2012 16:08:29 -0800 (PST)
Message-ID: <50C67989.7070401@mu.org>
Date: Mon, 10 Dec 2012 16:08:41 -0800
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r244098 - head/sys/kern
References: <201212102309.qBAN9uCf033959@svn.freebsd.org>
 <20121210231448.GX3013@kib.kiev.ua> <50C67272.4080008@mu.org>
 <50C6756B.80607@mu.org>
In-Reply-To: <50C6756B.80607@mu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Alfred Perlstein <alfred@freebsd.org>, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2012 00:08:29 -0000

On 12/10/12 3:51 PM, Alfred Perlstein wrote:
> On 12/10/12 3:38 PM, Alfred Perlstein wrote:
>> On 12/10/12 3:14 PM, Konstantin Belousov wrote:
>>> On Mon, Dec 10, 2012 at 11:09:56PM +0000, Alfred Perlstein wrote:
>>>> Author: alfred
>>>> Date: Mon Dec 10 23:09:55 2012
>>>> New Revision: 244098
>>>> URL: http://svnweb.freebsd.org/changeset/base/244098
>>>>
>>>> Log:
>>>>    make sysctls kern.{bootfile,conftxt} read-only
>>> You just break installkernel.
>> My apologies, give me a few moments to double check this and I will 
>> back out.
>
> So first off "installkernel" was not broken, the error is ignored by 
> make, hence why I didn't see it.
>
> Second off, this is pretty broken, the first time you "installkernel" 
> it gets it right, the second time it just seems to set kern.bootfile 
> to /boot/kernel.old/kernel no even though that's not really the boot 
> kernel.
>
> I will back out the change, but this just seems off.
>
> If we are going to change kern.bootfile, then we ought to detect when 
> it's no longer valid at all and just zero it.  or pretty much do 
> something else.
>
> -Alfred
>
and.. derp.  Florian explained how this works, how it doesn't rename 
kern.bootfile after the first rename of the kernel.

I'll be backing out the change now and adding some comments to the code 
shortly.