From owner-svn-src-stable@FreeBSD.ORG  Thu Jun 18 21:02:44 2009
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F24C6106564A;
	Thu, 18 Jun 2009 21:02:43 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id ACFBA8FC12;
	Thu, 18 Jun 2009 21:02:43 +0000 (UTC) (envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id EB7B86D418;
	Thu, 18 Jun 2009 23:02:42 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id C9C4784573; Thu, 18 Jun 2009 23:02:42 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: John Baldwin <jhb@freebsd.org>
References: <200906171731.n5HHVktG082752@svn.freebsd.org>
	<alpine.BSF.2.00.0906181414270.40949@woozle.rinet.ru>
	<86iqit5sms.fsf@ds4.des.no> <200906181455.26797.jhb@freebsd.org>
Date: Thu, 18 Jun 2009 23:02:42 +0200
In-Reply-To: <200906181455.26797.jhb@freebsd.org> (John Baldwin's message of
	"Thu, 18 Jun 2009 14:55:26 -0400")
Message-ID: <86eith5k7h.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, svn-src-stable-7@freebsd.org,
	Dmitry Morozovsky <marck@rinet.ru>
Subject: Re: svn commit: r194377 - stable/7/sys/dev/ath/ath_hal
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
	<svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>, 
	<mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
	<mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2009 21:02:44 -0000

John Baldwin <jhb@freebsd.org> writes:
> I think Dmitry means more that all the prop changes stuff clutters the ac=
tual=20
> commit messages.  I would like to see them removed from the subject line =
at=20
> least so that the subject line clearly shows where real changes are being=
=20
> made.

That's reasonable - but I would still very much like to see prop changes
in the commit email.  It's not just svn:mergeinfo, there have also been
cases of incorrect svn:keywords, and even someone who set svn:mime-type
to application/octet-stream on a couple of files because they couldn't
figure out the correct svn:keywords syntax.

BTW, if you do as Dmitry suggests, how will you handle props-only
commits like r192599, r192646 or r192653?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no