From owner-freebsd-bugs@freebsd.org Thu Feb 13 07:11:54 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB03624F9E9 for ; Thu, 13 Feb 2020 07:11:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 48J73t55MPz4ZrF for ; Thu, 13 Feb 2020 07:11:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id ACE0B24F9E8; Thu, 13 Feb 2020 07:11:54 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACA6C24F9E7 for ; Thu, 13 Feb 2020 07:11:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48J73t49lgz4ZrD for ; Thu, 13 Feb 2020 07:11:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8A9DF6D8E for ; Thu, 13 Feb 2020 07:11:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01D7BsrJ040782 for ; Thu, 13 Feb 2020 07:11:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01D7Bs1R040781 for bugs@FreeBSD.org; Thu, 13 Feb 2020 07:11:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 243974] diff(1) generates core dump when --tabsize is used Date: Thu, 13 Feb 2020 07:11:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: crash, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fnoyanisi@yahoo.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2020 07:11:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243974 --- Comment #3 from fehmi noyan isi --- POC for the proposed patch fnoyanisi@patch:~ $ diff A B 1,5c1,3 < same1 < differ1 <=20 <=20 < differ3 --- > same1=20=20 > differ2 > differ4 fnoyanisi@patch:~ $ diff A B --tabsize 4 Segmentation fault (core dumped) // After the patch fnoyanisi@patch:~ $ diff A B --tabsize 4 1,5c1,3 < same1 < differ1 <=20 <=20 < differ3 --- > same1=20=20 > differ2 > differ4 fnoyanisi@patch:~ $ uname -a FreeBSD patch 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r357606: Thu Feb 6 04:4= 0:35 UTC 2020=20=20=20=20 root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 fnoyanisi@patch:~ $=20 // No failing ATF tests root@patch:/usr/tests # kyua test -k /usr/tests/Kyuafile usr.bin/diff usr.bin/diff/diff_test:Bflag -> passed [0.191s] usr.bin/diff/diff_test:b230049 -> passed [0.054s] usr.bin/diff/diff_test:brief_format -> passed [0.180s] usr.bin/diff/diff_test:group_format -> passed [0.064s] usr.bin/diff/diff_test:header -> passed [0.066s] usr.bin/diff/diff_test:header_ns -> passed [0.063s] usr.bin/diff/diff_test:ifdef -> passed [0.060s] usr.bin/diff/diff_test:side_by_side -> passed [0.130s] usr.bin/diff/diff_test:simple -> passed [0.230s] usr.bin/diff/diff_test:unified -> passed [0.097s] usr.bin/diff/netbsd_diff_test:mallocv -> passed [0.069s] usr.bin/diff/netbsd_diff_test:nomallocv -> passed [0.070s] usr.bin/diff/netbsd_diff_test:same -> passed [0.071s] Results file id is usr_tests.20200213-193818-429125 Results saved to /root/.kyua/store/results.usr_tests.20200213-193818-429125= .db 13/13 passed (0 failed) root@patch:/usr/tests #=20 There is another diff(1) patch I am working on [1] but I am reluctant to su= bmit more than one patch for the same source file at once. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243975 --=20 You are receiving this mail because: You are the assignee for the bug.=