From owner-cvs-all  Mon Dec 11 16:34:50 2000
From owner-cvs-all@FreeBSD.ORG  Mon Dec 11 16:34:44 2000
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from bsdhome.dyndns.org (unknown [24.25.2.13])
	by hub.freebsd.org (Postfix) with ESMTP
	id DBCC237B402; Mon, 11 Dec 2000 16:34:43 -0800 (PST)
Received: from vger.bsdhome.com (vger [192.168.220.2])
	by bsdhome.dyndns.org (8.11.1/8.11.1) with ESMTP id eBC0YWt03453;
	Mon, 11 Dec 2000 19:34:32 -0500 (EST)
	(envelope-from bsd@bsdhome.com)
Received: (from bsd@localhost)
	by vger.bsdhome.com (8.11.1/8.11.1) id eBC0YQv53092;
	Mon, 11 Dec 2000 19:34:26 -0500 (EST)
	(envelope-from bsd)
Date: Mon, 11 Dec 2000 19:34:26 -0500
From: Brian Dean <bsd@bsdhome.com>
To: "David E. O'Brien" <obrien@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc rc
Message-ID: <20001211193426.B52569@vger.bsdhome.com>
References: <200012112247.eBBMlo852648@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200012112247.eBBMlo852648@freefall.freebsd.org>; from obrien@FreeBSD.org on Mon, Dec 11, 2000 at 02:47:50PM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Mon, Dec 11, 2000 at 02:47:50PM -0800, David E. O'Brien wrote:
> obrien      2000/12/11 14:47:50 PST
> 
>   Modified files:
>     etc                  rc 
>   Log:
>   Set portmap_enable if Amd or running as an NFS server is enabled.
>   This bites too many systems upgrading from our change in defaults.

Perhaps a notice should be echoed in this case that something is being
enabled that wasn't explicity asked for in rc.conf?  Something like
this (to modify your commit a bit):

	# Deal with dependancies.
 	case ${amd_enable} in
	[Yy][Ee][Ss])
	    case ${portmap_enable} in
		[Yy][Ee][Ss])
		    ;;
		*)
		    portmap_enable="YES"
		    echo "DEPENDENCY NOTE: portmap will be enabled to support amd"
		    ;;
	    esac
	    ;;
	esac

	case ${nfs_server_enable} in
	[Yy][Ee][Ss])
	    if [ -r /etc/exports ]; then
		case ${portmap_enable} in
		[Yy][Ee][Ss])
		    ;;
		*)
		    portmap_enable="YES"
		    echo "DEPENDENCY NOTE: portmap will be enabled to support nfs"
		    ;;
		esac
	    fi
	    ;;
	esac

Any objections?

-Brian


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message