From owner-p4-projects@FreeBSD.ORG Sun Nov 12 07:09:27 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9AD7F16A416; Sun, 12 Nov 2006 07:09:27 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D8F616A403; Sun, 12 Nov 2006 07:09:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1F3543D53; Sun, 12 Nov 2006 07:09:26 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kAC76I2p066225; Sun, 12 Nov 2006 00:06:18 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 12 Nov 2006 00:06:53 -0700 (MST) Message-Id: <20061112.000653.-1303463784.imp@bsdimp.com> To: andre@freebsd.org From: "M. Warner Losh" In-Reply-To: <200611101935.kAAJZmWW099731@repoman.freebsd.org> References: <200611101935.kAAJZmWW099731@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 12 Nov 2006 00:06:19 -0700 (MST) Cc: perforce@freebsd.org Subject: Re: PERFORCE change 109699 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2006 07:09:27 -0000 In message: <200611101935.kAAJZmWW099731@repoman.freebsd.org> Andre Oppermann writes: : http://perforce.freebsd.org/chv.cgi?CH=109699 : : Change 109699 by andre@andre_flirtbox on 2006/11/10 19:35:44 : : Increase EEPROMSIZE to 16384 as the boot2 loader is slighly larger than : 8192 bytes. : Get the printing of EEPROMSIZE right. This change is wrong. The largest loader you can have is 12kb, not 16kb. Warner : Affected files ... : : .. //depot/projects/arm/src/sys/boot/arm/at91/boot0iic/main.c#9 edit : : Differences ... : : ==== //depot/projects/arm/src/sys/boot/arm/at91/boot0iic/main.c#9 (text) ==== : : @@ -28,7 +28,7 @@ : #include "lib.h" : #include "at91rm9200_lowlevel.h" : : -#define EEPROMSIZE 8192 /* Bytes to be written to EEPROM */ : +#define EEPROMSIZE 16384 /* Bytes to be written to EEPROM */ : : int : main(void) : @@ -36,12 +36,12 @@ : char *addr = (char *)SDRAM_BASE + (1 << 20); /* Load to base + 1MB */ : : printf("\r\nSend data to be written into EEPROM at addr 0 " : - "(EEPROMSIZE bytes)\r\n"); : + "(0x%x bytes)\r\n", EEPROMSIZE); : : while (xmodem_rx(addr) == -1) : continue; : InitEEPROM(); : - printf("\r\nWriting EEPROM from 0x%x to addr 0, EEPROMSIZE bytes\r\n", addr); : + printf("\r\nWriting EEPROM from 0x%x to addr 0, 0x%x bytes\r\n", addr, EEPROMSIZE); : WriteEEPROM(0, addr, EEPROMSIZE); : printf("\r\nWrite complete. Press reset\r\n"); : return (1); :