Date: Thu, 12 Oct 2017 05:04:55 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: maintainer-feedback requested: [Bug 222942] misc/xfce4-weather-plugin: Update to 0.8.10 Message-ID: <bug-222942-28711-K6wNBGvYmG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-222942-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-222942-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Olivier Duchateau <duchateau.olivier@gmail.com> has reassigned Bugzilla Automation <bugzilla@FreeBSD.org>'s request for maintainer-feedback to xfce@FreeBSD.org: Bug 222942: misc/xfce4-weather-plugin: Update to 0.8.10 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222942 --- Description --- Created attachment 187091 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D187091&action= =3Dedit Patch to update misc/xfce4-weather-plugin - Update to 0.8.10 - Remove unneeded patch Note: tested with xfce4-panel 4.13.1 (Gtk3 only) I noticed some icons disappeared (since switch to Gtk3, icons in panel are loaded differently), = so in panel 4.12.x everythin should be fine. Moreover in my 4.13 branch [1], I have patch, which fixes logical GtkOrientation enum (previous releases are also affected): weather.c:2035:31: warning: implicit conversion from enumeration type 'XfcePanelPluginMode' to different enumeration type 'GtkOrientation' [-Wenum-conversion] data->panel_orientation =3D xfce_panel_plugin_get_mode(panel); ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ weather.c:2038:34: warning: comparison of constant 'XFCE_PANEL_PLUGIN_MODE_DESKBAR' (2) with expression of type 'GtkOrientatio= n' is always false [-Wtautological-constant-out-of-range-compare] (data->panel_orientation =3D=3D XFCE_PANEL_PLUGIN_MODE_DESKBAR && ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ As my patch is not yet review by upstream, and follow the FreeBSD Xfce team= 's policy i'm waiting in order to propose my patch in the official ports tree. [1] https://app.assembla.com/spaces/xfce4/subversion/source/HEAD/tags/4.13/misc= /xfc e4-weather-plugin/files/patch-panel-plugin_weather.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-222942-28711-K6wNBGvYmG>