Date: Mon, 8 Mar 2010 14:51:23 -0500 From: David Schultz <das@FreeBSD.ORG> To: Andrey Chernov <ache@nagual.pp.ru>, Bruce Evans <brde@optusnet.com.au>, Jaakko Heinonen <jh@FreeBSD.ORG>, src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG Subject: Re: svn commit: r204803 - head/usr.bin/uniq Message-ID: <20100308195123.GA10624@zim.MIT.EDU> In-Reply-To: <20100307201027.GA51623@nagual.pp.ru> References: <201003061921.o26JLv36014114@svn.freebsd.org> <20100307104626.GA9015@a91-153-117-195.elisa-laajakaista.fi> <20100308015926.O11669@delplex.bde.org> <20100307183139.GA50243@nagual.pp.ru> <20100307201027.GA51623@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 07, 2010, Andrey Chernov wrote: > On Sun, Mar 07, 2010 at 09:31:39PM +0300, Andrey Chernov wrote: > > It is right idea. I'll use sysconf(__SC_LINE_MAX) there. > > But currently it does the same (sysconf.c): > > case _SC_LINE_MAX: > > return (LINE_MAX); > ... > > To add more: > > NetBSD uniq grows (contrary, NetBSD comm silently discarding everything > > afterwards). > > OpenBSD uniq just use fgets with 8192. > > GNU uniq grows. > > After thinking a bit more I consider to reimplement unlimited lines here > instead because enforcing POSIX limit was not the main goal of my commit > (it was to remove getwc() which is evil). Someone may deal with the limit > on his own way afterwards. Good. I think it's better for usability if we avoid artificial limits like this. You can actually just call getline() rather than reinventing the wheel. I've had a wide character version of getline() ready to commit for some time (I just need to find the time to do it), so you won't need to call mbstowcs() as a separate step.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100308195123.GA10624>