Date: Wed, 28 Mar 2012 21:10:59 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/miniupnpc/files miniupnpc.in Message-ID: <4F73E0D3.90807@FreeBSD.org> In-Reply-To: <201203251429.q2PET8Bo038362@repoman.freebsd.org> References: <201203251429.q2PET8Bo038362@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Overall this is not bad, just some small things that can wait till the next version if you prefer: 1. It needs a $FreeBSD$ 2. The lines after run_rc_command should be deleted. See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more info. Doug On 3/25/2012 7:29 AM, Dirk Meyer wrote: > dinoex 2012-03-25 14:29:08 UTC > > FreeBSD ports repository > > Added files: > net/miniupnpc/files miniupnpc.in > Log: > - add rc.d script > Submitted by: Andrey Chernov > Feature safe: yes > > Revision Changes Path > 1.1 +33 -0 ports/net/miniupnpc/files/miniupnpc.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/miniupnpc/files/miniupnpc.in >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F73E0D3.90807>