From owner-svn-src-head@freebsd.org Mon Jul 23 16:41:14 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB8B7104F9EF; Mon, 23 Jul 2018 16:41:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EF3BD83FC2; Mon, 23 Jul 2018 16:41:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id hdtVfgIcZWppDhdtXf3HnK; Mon, 23 Jul 2018 10:41:12 -0600 X-Authority-Analysis: v=2.3 cv=YIcrNiOx c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=BOkEnWI0whRbsa-jNy0A:9 a=MfmKj_gv5cle6sVY:21 a=P1TnRRUsIJ0jbRFj:21 a=QEXdDO2ut3YA:10 a=dADgekYTktasRz0T3RUA:9 a=Y2boIxRUT9h_c8cq:21 a=DSnrlnj8TO91vq9H:21 a=LSsBcuTZuvz0Z21g:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.80.33.197] (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id 40C7E948; Mon, 23 Jul 2018 09:41:15 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: svn commit: r336619 - head/lib/libc/gen Date: Mon, 23 Jul 2018 09:41:18 -0700 To: Alan Somers CC: Ian Lepore , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <20180723164115.40C7E948@spqr.komquats.com> X-CMAE-Envelope: MS4wfGsjxmy2T5v21fXHW7++4MR8sZ4VSgJpAu9eCyXM3C1Da+KeS9ubrrNpluGuZ1OVlw73q3JrE100J3n38T+pTwzahQxUeDbvQ0x69dCnv8ufgGVSiFYu oGFcdrakWj+0SZRHcFdAaLVoNANbyiv9Ki4Ub3GvsTzjWQtn889p3KlTZDmQ/aRn6oyfgQ+VQvkqP0NnwvMmXK9wIZw8tvJ6h+Gag1UVlS1gq/30qZDkNTnn pkicH8YjhzT1VL9G691RMo6rtY0Hh72KR5kcQgJsi8cm4CbNJXnDwbTLK28P5njn2asPskmNSX/UPjKW/l+d6rgrR/Hsqj1e91arhr38AGE= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 16:41:14 -0000 I'm sure. Rolling this libc commit back addressed the ssh segfaults on all = my systems. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Alan Somers Sent: 23/07/2018 07:48 To: Cy Schubert Cc: Ian Lepore; src-committers; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: Re: svn commit: r336619 - head/lib/libc/gen On Sun, Jul 22, 2018 at 11:13 PM, Cy Schubert w= rote: In message <201807222234.w6MMYKpn030237@repo.freebsd.org>, Ian Lepore=20 writes: =20 > Author: ian > Date: Sun Jul 22 22:34:20 2018 > New Revision: 336619 > URL: https://svnweb.freebsd.org/changeset/base/336619 > > Log: > Set the pw_class field to NULL when scanning the non-master passwd fil= e. > This avoids a null pointer deref in pw_dup(), which assumes that all > pointers are either NULL or valid. > > Modified: > head/lib/libc/gen/pw_scan.c > =20 Hi Ian, =20 This causes ssh a bit of gas. =20 Are you sure, Cy? Judging by the Jenkins output, I think it was the next r= evision to pw (336625) that broke everything. https://ci.freebsd.org/job/F= reeBSD-head-amd64-test/8320/ . -Alan =