From owner-freebsd-current@FreeBSD.ORG  Fri Nov 28 18:54:27 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D8438F92
 for <freebsd-current@freebsd.org>; Fri, 28 Nov 2014 18:54:27 +0000 (UTC)
Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com
 [IPv6:2a00:1450:400c:c05::22e])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6B981607
 for <freebsd-current@freebsd.org>; Fri, 28 Nov 2014 18:54:27 +0000 (UTC)
Received: by mail-wi0-f174.google.com with SMTP id h11so19399270wiw.1
 for <freebsd-current@freebsd.org>; Fri, 28 Nov 2014 10:54:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=GXh6LMy4CLKZmg/WlOCxf4Nik8lPERpnaq6Hq11bn30=;
 b=f5Xc/1gDqgAuC/Pci+Q04xOSu+5cL6dWB5YZfIKLua66UyifEnFbzMmm2eL3jMSA+l
 AMZWCtgDFXb9xPRZxGSsuQa1VdnZmW1blZ/zuU3F1XQGJJUwf7r/NKptGfEozZ7d5keK
 3qdl37z0rW+GZ3MLF2gX7DhDuI7WhDhs8F8C1LC2p3WuCAZrsFWrdCyve0ctOlTANBbn
 4u7ZHfZjRyXzIKO6P5dzgKnyS9A6co0pBMGpJ7y27pPPnD+bXLeUz/Qokl2JyE+JHdDe
 auEZHThcF8AGUINabJ2xx/If4rwQN3FYbAovk78iws8+8tYK76yZYQoW7XeM2UnQSRUi
 H2PQ==
MIME-Version: 1.0
X-Received: by 10.180.99.105 with SMTP id ep9mr63443270wib.26.1417200865753;
 Fri, 28 Nov 2014 10:54:25 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.216.106.136 with HTTP; Fri, 28 Nov 2014 10:54:25 -0800 (PST)
In-Reply-To: <20141128183416.GA71749@troutmask.apl.washington.edu>
References: <20141128183416.GA71749@troutmask.apl.washington.edu>
Date: Fri, 28 Nov 2014 10:54:25 -0800
X-Google-Sender-Auth: 54azjl9d3i5EQ3DogZ86dtGOLXw
Message-ID: <CAJ-Vmok8xHjK0Vjh5JRKbvSUv=3Rs=jhgCtboYbXPVc_yHii1A@mail.gmail.com>
Subject: Re: Possible bug in softfloat
From: Adrian Chadd <adrian@freebsd.org>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-current <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2014 18:54:27 -0000

On 28 November 2014 at 10:34, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> In a thread on comp.lang.c, it was pointed out that softfloat
> has a bug and in checking src/lib/libc/softfloat I confimed
> the issue is present in FreeBSD.  What I hae not confirmed
> is whether or not it is possible to hit this bug.  In fact,
> it may only hit arm and mips.  Anyway, here's the patch

So we should just commit this?


-a

>
>
> Index: softfloat/bits64/softfloat-macros
> ===================================================================
> --- softfloat/bits64/softfloat-macros   (revision 275211)
> +++ softfloat/bits64/softfloat-macros   (working copy)
> @@ -157,7 +157,7 @@
>          z0 = a0>>count;
>      }
>      else {
> -        z1 = ( count < 64 ) ? ( a0>>( count & 63 ) ) : 0;
> +        z1 = ( count < 128 ) ? ( a0>>( count & 63 ) ) : 0;
>          z0 = 0;
>      }
>      *z1Ptr = z1;
>
> --
> Steve
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"