From owner-freebsd-fs@FreeBSD.ORG Sat Jun 12 12:03:52 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EDF61065674; Sat, 12 Jun 2010 12:03:52 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id EBC0F8FC12; Sat, 12 Jun 2010 12:03:51 +0000 (UTC) Received: by iwn7 with SMTP id 7so2757516iwn.13 for ; Sat, 12 Jun 2010 05:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=9ZatU3tWlk1pC8R6lFZNJj8e/M82Zd+KnVRDq22mb5o=; b=tvPziFEhqbhjsVaTP7FGqXQVlR3JxArtPeT4FJzjY8VMKBFzdBB/qsoqvh5G9rf87D kqw8p/5mtq6P1Sfn0AYcYCbpy40FlePF0JbCDq5BCvxRKCPLW+sW2K9K4Gv0oXqJK/br X/8ra6nJovZLYTDuP6aapmXcaMOOWO8+A0HMg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=L5iZBofDC7KuP48FPFxwDTsuiqUTEzAjKXyj2uoqOZIK1iySp2EYePF9bWglnjbA7h knX876JGi61jG+RjrjAByoTzweAXCgIl4/gAvXBf+z+Wy8h3b7wB7bnb+aigTGf9Lbl8 HwZdyC//LPQOr8ETOFyAMD1BwC14b8xoTwuMo= Received: by 10.231.139.21 with SMTP id c21mr3176762ibu.160.1276344230877; Sat, 12 Jun 2010 05:03:50 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-128-180.dsl.klmzmi.sbcglobal.net [99.181.128.180]) by mx.google.com with ESMTPS id b3sm10149581ibf.13.2010.06.12.05.03.48 (version=SSLv3 cipher=RC4-MD5); Sat, 12 Jun 2010 05:03:49 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C1377A3.2040408@dataix.net> Date: Sat, 12 Jun 2010 08:03:47 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100515 Thunderbird MIME-Version: 1.0 To: Ivan Voras References: <20100610162629.38992mazf0sfdqg0@webmail.leidinger.net> <20100611172033.42001s90ahe57oe8@webmail.leidinger.net> In-Reply-To: X-Enigmail-Version: 1.0.1 OpenPGP: id=89D8547E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org, Alexander Leidinger Subject: Re: CFT: periodic scrubbing of ZFS pools X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 12:03:52 -0000 On 06/11/2010 12:11, Ivan Voras wrote: > On 11 June 2010 17:20, Alexander Leidinger wrote: >> Quoting Ivan Voras (from Fri, 11 Jun 2010 14:04:24 >> +0200): > >>> Fairly good and useful, but could you add a small check of "zpool >>> status" information before scrubbing that would a) complain LOUDLY AND >>> VISIBLY if a previous scrub failed and b) skip issuing a new scrub >>> command if there is such an error, to avoid stressing possibly broken >>> hardware? >> >> Can you please provide an example of such a failed scrub? > > You should probably treat any status message that doesn't have "none > requested" or "scrub completed with 0 errors..." as failed. I disagree with this as it conflicts with your previous request. none requested = no error and the next scrub should be allowed scrub completed with 0 errors = no errors. Why shouldn't the next scrub that is being determined in the script take place if there is no errors ?. I only see doing this if you want the scrub to only ever be performed once and never again thereafter. I do agree on the other hand if the scrub status has any form of [fF][aA][iI][dD] in it then it should not be performed and as well if it contains [fF][aA][uU][lL][tT][eE][dD] or some other combinations on one of the devices. Regards, -- jhell