From owner-svn-src-head@FreeBSD.ORG Sun Sep 23 10:52:25 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 120B0106564A; Sun, 23 Sep 2012 10:52:25 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 8071D8FC0C; Sun, 23 Sep 2012 10:52:24 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q8NAqWBm032189; Sun, 23 Sep 2012 13:52:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q8NAqKcB097698; Sun, 23 Sep 2012 13:52:20 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q8NAqK64097697; Sun, 23 Sep 2012 13:52:20 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 23 Sep 2012 13:52:20 +0300 From: Konstantin Belousov To: Kevin Lo Message-ID: <20120923105220.GL37286@deviant.kiev.zoral.com.ua> References: <201209230838.q8N8c6Tu056083@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l/31HQTn6peyh0iH" Content-Disposition: inline In-Reply-To: <201209230838.q8N8c6Tu056083@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240850 - head/lib/libstand X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2012 10:52:25 -0000 --l/31HQTn6peyh0iH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 23, 2012 at 08:38:06AM +0000, Kevin Lo wrote: > Author: kevlo > Date: Sun Sep 23 08:38:06 2012 > New Revision: 240850 > URL: http://svn.freebsd.org/changeset/base/240850 >=20 > Log: > Avoid NULL dereference >=20 > Modified: > head/lib/libstand/nfs.c >=20 > Modified: head/lib/libstand/nfs.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libstand/nfs.c Sun Sep 23 07:43:10 2012 (r240849) > +++ head/lib/libstand/nfs.c Sun Sep 23 08:38:06 2012 (r240850) > @@ -1256,8 +1256,10 @@ nfs_open(const char *upath, struct open_ > error =3D 0; > =20 > out: > - free(newfd); > - free(path); > + if (newfd) > + free(newfd); > + if (path) > + free(path); > #else > currfd->iodesc =3D desc; > =20 I do not see how this change is useful. libstand' Free() function handles NULL parameter fine, as well as all other free(3) implementations I am aware of. --l/31HQTn6peyh0iH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBe6eQACgkQC3+MBN1Mb4hugQCg52Fn6t82hUyiF2758uxHvo8I ODwAmgIE8px9fFG4S+rlBSl/awVotObJ =eZI4 -----END PGP SIGNATURE----- --l/31HQTn6peyh0iH--