From owner-freebsd-current  Fri Jul 28 15:33: 5 2000
Delivered-To: freebsd-current@freebsd.org
Received: from feral.com (feral.com [192.67.166.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 69E7037BE87; Fri, 28 Jul 2000 15:32:39 -0700 (PDT)
	(envelope-from mjacob@feral.com)
Received: from beppo.feral.com (beppo [192.67.166.79])
	by feral.com (8.9.3/8.9.3) with ESMTP id PAA11423;
	Fri, 28 Jul 2000 15:32:35 -0700
Date: Fri, 28 Jul 2000 15:32:38 -0700 (PDT)
From: Matthew Jacob <mjacob@feral.com>
Reply-To: mjacob@feral.com
To: Poul-Henning Kamp <phk@FreeBSD.ORG>
Cc: current@FreeBSD.ORG
Subject: Re: a FS related patch to test please...
In-Reply-To: <281.964813824@critter.freebsd.dk>
Message-ID: <Pine.BSF.4.10.10007281532340.63390-100000@beppo.feral.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

FWIW, works for me


On Fri, 28 Jul 2000, Poul-Henning Kamp wrote:

> 
> I'm in my beach-house and pretty offline right now, but I reviewed the
> change Kirk did to addaliasu() and found at least one scenario where
> it wouldn't do what he expected:
> 
> If bdevvp() is called more than once with the same dev_t we would
> create more than one anonymous vnode for that dev_t and addaliasu()
> would only get one of these in its yarn.  This patch makes bdevvp()
> only produce max one anonymous vnode per dev_t.
> 
> I don't know if the new rootfs-locating code calls bdevvp() more
> than once, if it doesn't this patch is a harmless bit of overhead.
> 
> Please test, and if it doesn't do any harm I will commit it.
> 
> (This does not fix the panic everybody is talking about btw)
> 
> Poul-Henning
> 
> 
> Index: vfs_subr.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/vfs_subr.c,v
> retrieving revision 1.267
> diff -u -r1.267 vfs_subr.c
> --- vfs_subr.c	2000/07/24 05:28:29	1.267
> +++ vfs_subr.c	2000/07/28 19:08:36
> @@ -1276,6 +1276,8 @@
>  		*vpp = NULLVP;
>  		return (ENXIO);
>  	}
> +	if (vfinddev(dev, VCHR, vpp))
> +		return (0);
>  	error = getnewvnode(VT_NON, (struct mount *)0, spec_vnodeop_p, &nvp);
>  	if (error) {
>  		*vpp = NULLVP;
> --
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD coreteam member | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message