Date: Sun, 27 Oct 2019 15:26:13 +0100 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: Kirill Ponomarev <krion@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r515759 - in head/sysutils/py-salt: . files Message-ID: <20191027142613.GA2468@elch.exwg.net> In-Reply-To: <201910270923.x9R9NYAC019983@repo.freebsd.org> References: <201910270923.x9R9NYAC019983@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
## Kirill Ponomarev (krion@FreeBSD.org): > Log: > Fix master/minion run with python3 That's misleading - the problem here was not python3 (in fact, python2 support in saltstack has been deprecated) but the fact that the salt team pinned the PyYAML dependency to an old version after some problem with some unit tests: https://github.com/saltstack/salt/commit/cee9480ee3d40b8a17c02144080ca02a834688b1 (As salt didn't show any sign of memory leaks during normal operations, I won't complain about the fix per se, but the commit message should get the facts right.) But while I'm here: that msgpack-python/msgpack replacement in py-salt's Makefile line 97 https://svnweb.freebsd.org/ports/head/sysutils/py-salt/Makefile?revision=515759&view=markup&sortby=date#l97 is obsolete, that has been fixed upstream: https://github.com/saltstack/salt/commit/84aa034e032e6fa2f9c9cc136267b348527bb22e (that's why I'm a big fan of patch files - they make these cases obvious) Oh, and our PyYAML could take an update: https://pypi.org/project/PyYAML/ Damn, how did I get into this rabbit's hole? Regards, Christoph -- Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191027142613.GA2468>