From nobody Mon Dec 1 20:52:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dKx1b3dGtz6Hcmp for ; Mon, 01 Dec 2025 20:52:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dKx1b0hsHz3C0s for ; Mon, 01 Dec 2025 20:52:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764622371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RS6qP0TO3+qdeurrI6vrhkbLyvhrXie8I3s8zU3MBb8=; b=U3tv7K9Utp6Qv8Xqoa7HHtmf8WoQyyokrqaOlCDsP8w8IeHHAa+anqFz1+vVGNZtq/8CrH PPoftJcnHjU1lXtS2RBafrAjZdWc1hwq9gmCiK0TbZdDGVZlqefS7dVXXCzjJnKF1hkyQM +H+3BKexfAtBIClO/Js/4ebZ0QuZqKno+rQeUu546nEK8A7dOVdqUAyVrF56MdnJA2BCjH ljKXLeq3vaWj7Gbe4q++Q/rpPTwugAuJfWXsnSXRGktEu37D3uxEG0cAHGFX0OsWmG5wYz JTpP0dBXsct0kw6GLpwo2Z9bSP7V9fg5XCfUMyXitA3VoGIt4O5nO9taI/0fJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764622371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RS6qP0TO3+qdeurrI6vrhkbLyvhrXie8I3s8zU3MBb8=; b=gYH5G4z21b1jBOsYQPGSzmD9BBtoyMzDKv7IDbn7kEABwS93bSUPrHphl+UrONK1YtBCPR fCBEqCK0OJGZrCoV6AgyCj62jHGBWKwmzm12w/TyvHizbxL/bTWRqs0WVgxh2zgYMq9kYy Jh0VRLf159v/V5OjwE2ooF/dkMelEiltI4/29PNQ1imOY1g0IPlyjwMrITj6Zvu4SjhRlw DtlIBiYrWhSJarpRy9y7zrDuH7dAw6Bc+6WyGO/l3PYK394jXWat7UYhwp6phDplSvbKB4 XL7q8jfaQ1TW7bmsXNJKVbTaQdfiu+GankRRUfRSIMhaxMl2Ct93FJ11k31LHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764622371; a=rsa-sha256; cv=none; b=sfMweIQrHPX1PCtlllNC1k2QhvDSpq9Kxi5f21klkM/+lcXzNaUH+j56XFFWaCUsnJ8+0J GBcWawhwVwZwX1h9POPjx9XJzCYgSaoM5o3BnX5g79wKWQYHlI3V/s4DQ1htJmDgbfGOJH 9MnWHOHjJCGjsllRuxGaqARMa//ARM/qFEXgAaLhgyPB207nI0SSqKCrsyrlmjSsuU6LSX 548zn3iAT5dxgovObKWVhFljeWi7enneuJbr/48QKc2l6rf9LS6HvanH8BzIRMlTJ0/lYS U2001cKfWg7lH2+EmFsfaqD0dbwuC0Py9+rYcU8A5qcTPKg06JQFJW6TNY473g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dKx1Z6x0vzcqs for ; Mon, 01 Dec 2025 20:52:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 324d6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 01 Dec 2025 20:52:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Peek Subject: git: 732b4aa05d78 - main - ctfmerge: fix segfault when building on macOS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 732b4aa05d78ca6831d02e67a43f34ad104f4f01 Auto-Submitted: auto-generated Date: Mon, 01 Dec 2025 20:52:50 +0000 Message-Id: <692e0022.324d6.525dccf4@gitrepo.freebsd.org> The branch main has been updated by mp: URL: https://cgit.FreeBSD.org/src/commit/?id=732b4aa05d78ca6831d02e67a43f34ad104f4f01 commit 732b4aa05d78ca6831d02e67a43f34ad104f4f01 Author: Mark Peek AuthorDate: 2025-12-01 20:50:24 +0000 Commit: Mark Peek CommitDate: 2025-12-01 20:50:24 +0000 ctfmerge: fix segfault when building on macOS The barrier code was using semaphores which have been deprecated in macOS and not working at all, causing a race condition. Since macOS does not have pthread_barrier_*(), this change uses a condition variable instead. PR: 290958 Reported by: wosch MFC after: 2 weeks Reviewed by: imp, markj Differential Revision: https://reviews.freebsd.org/D54018 --- cddl/contrib/opensolaris/tools/ctf/cvt/barrier.c | 26 +++--------------------- cddl/contrib/opensolaris/tools/ctf/cvt/barrier.h | 9 ++------ 2 files changed, 5 insertions(+), 30 deletions(-) diff --git a/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.c b/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.c index c0719620dbde..e1f54e994ce3 100644 --- a/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.c +++ b/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.c @@ -38,9 +38,6 @@ */ #include -#ifdef illumos -#include -#endif #include #include "barrier.h" @@ -49,12 +46,7 @@ void barrier_init(barrier_t *bar, int nthreads) { pthread_mutex_init(&bar->bar_lock, NULL); -#ifdef illumos - sema_init(&bar->bar_sem, 0, USYNC_THREAD, NULL); -#else - sem_init(&bar->bar_sem, 0, 0); -#endif - + pthread_cond_init(&bar->bar_cv, NULL); bar->bar_numin = 0; bar->bar_nthr = nthreads; } @@ -65,26 +57,14 @@ barrier_wait(barrier_t *bar) pthread_mutex_lock(&bar->bar_lock); if (++bar->bar_numin < bar->bar_nthr) { + pthread_cond_wait(&bar->bar_cv, &bar->bar_lock); pthread_mutex_unlock(&bar->bar_lock); -#ifdef illumos - sema_wait(&bar->bar_sem); -#else - sem_wait(&bar->bar_sem); -#endif return (0); - } else { - int i; - /* reset for next use */ bar->bar_numin = 0; - for (i = 1; i < bar->bar_nthr; i++) -#ifdef illumos - sema_post(&bar->bar_sem); -#else - sem_post(&bar->bar_sem); -#endif + pthread_cond_broadcast(&bar->bar_cv); pthread_mutex_unlock(&bar->bar_lock); return (1); diff --git a/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.h b/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.h index babf2e64e33f..138386f8ed46 100644 --- a/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.h +++ b/cddl/contrib/opensolaris/tools/ctf/cvt/barrier.h @@ -33,12 +33,7 @@ * APIs for the barrier synchronization primitive. */ -#ifdef illumos -#include -#else -#include -typedef sem_t sema_t; -#endif +#include #ifdef __cplusplus extern "C" { @@ -48,7 +43,7 @@ typedef struct barrier { pthread_mutex_t bar_lock; /* protects bar_numin */ int bar_numin; /* current number of waiters */ - sema_t bar_sem; /* where everyone waits */ + pthread_cond_t bar_cv; /* where everyone waits */ int bar_nthr; /* # of waiters to trigger release */ } barrier_t;