Date: Thu, 3 Feb 2000 14:12:53 -0800 From: Chris Piazza <cpiazza@FreeBSD.org> To: Archie Cobbs <archie@whistle.com> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: need help with portlint Message-ID: <20000203141253.B352@norn.ca.eu.org> In-Reply-To: <200002032111.NAA99204@bubba.whistle.com>; from archie@whistle.com on Thu, Feb 03, 2000 at 01:11:40PM -0800 References: <200002032111.NAA99204@bubba.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 03, 2000 at 01:11:40PM -0800, Archie Cobbs wrote: > Hello, > Need some help with portlint (for the security/skip port).. > > WARN: use of IS_INTERACTIVE discouraged. provide batch > mode by using BATCH and/or FOR_CDROM. > > Until there is a batch mode (which right now there isn't), > should I just leave the IS_INTERACTIVE in there? If the port is interactive, yes. > > WARN: no MASTER_SITES found. is it ok? > FATAL: no MAINTAINER listed in Makefile. > WARN: "MASTER_SITES" has to appear earlier in Makefile. > WARN: "EXTRACT_SUFX" has to appear earlier in Makefile. > WARN: "DISTFILES" has to appear earlier in Makefile. > WARN: "MAINTAINER" has to appear earlier in Makefile. > WARN: "LIB_DEPENDS" has to appear earlier in Makefile. > WARN: "BUILD_DEPENDS" has to appear earlier in Makefile. > > These I don't understand. Every time I try to reorder things (I'm > randomly reordering things because I have no idea what to do), I > still get that all this stuff ``has to appear earlier in Makefile'' > Everything can't appear earlier than everything else! How about > portlint telling me what the right order is because I can't try > all factorial(21) possibilities. And MAINTAINER is listed.. > why is it compliaining that it's not? > > I read http://www.freebsd.org/~asami/cvsguide.txt but it doesn't > comment on Makefile preparation. > > The Makefile is included below. Thanks for any help. The problem is how you have the DISTNAME/CATEGORIES/etc section set up. Here's a patch that fixes all but two of the warnings (one of them being the interactive part..). DISTNAME should be the name of the distfile without the EXTRACT_SUFX and PKGNAME should be added if DISTNAME isn't a suitable package name. Also DESCR is supposed to be 24 lines maximum. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/security/skip/Makefile,v retrieving revision 1.17 diff -u -r1.17 Makefile --- Makefile 2000/02/01 18:39:05 1.17 +++ Makefile 2000/02/03 22:11:25 @@ -5,18 +5,15 @@ # # $FreeBSD: ports/security/skip/Makefile,v 1.17 2000/02/01 18:39:05 archie Exp $ -DISTNAME= skip-1.0 +DISTNAME= skipsrc-1.0 +PKGNAME= skip-1.0 CATEGORIES= security - # Note: the original source comes from Sun, via this web page: # http://skip.incog.com/src-form.html # The site below is outside of the U.S. - MASTER_SITES= ftp://ftp.replaytv.com/pub/replay/crypto/APPS/skip/ \ ftp://ftp.internat.freebsd.org/pub/FreeBSD/distfiles/ - -DISTFILES= skipsrc-1.0.tar.Z -EXTRACT_SUFX= tar.Z +EXTRACT_SUFX= .tar.Z MAINTAINER= archie@freebsd.org Index: pkg/DESCR =================================================================== RCS file: /home/ncvs/ports/security/skip/pkg/DESCR,v retrieving revision 1.2 diff -u -r1.2 DESCR --- pkg/DESCR 1999/05/03 04:04:43 1.2 +++ pkg/DESCR 2000/02/03 22:11:26 @@ -1,8 +1,6 @@ - This is from http://skip.incog.com: SKIP - Simple Key management for Internet Protocols - IP-Level Cryptography Secure every application with one protocol -Chris -- cpiazza@jaxon.net cpiazza@FreeBSD.org Abbotsford, BC, Canada To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000203141253.B352>