From owner-freebsd-current Mon Nov 25 19: 8: 8 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04B0A37B401; Mon, 25 Nov 2002 19:08:07 -0800 (PST) Received: from lakemtao02.cox.net (lakemtao02.cox.net [68.1.17.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EAFF43EA9; Mon, 25 Nov 2002 19:08:06 -0800 (PST) (envelope-from ataraxia@cox.net) Received: from arkadia.nv.cox.net ([68.98.181.29]) by lakemtao02.cox.net (InterMail vM.5.01.04.05 201-253-122-122-105-20011231) with ESMTP id <20021126030803.DGAX2203.lakemtao02.cox.net@arkadia.nv.cox.net>; Mon, 25 Nov 2002 22:08:03 -0500 Received: from arkadia.nv.cox.net (localhost [127.0.0.1]) by arkadia.nv.cox.net (8.12.6/8.12.6) with ESMTP id gAQ384vF052406; Mon, 25 Nov 2002 22:08:05 -0500 (EST) (envelope-from ataraxia@arkadia.nv.cox.net) Received: (from ataraxia@localhost) by arkadia.nv.cox.net (8.12.6/8.12.6/Submit) id gAQ3845p052405; Mon, 25 Nov 2002 22:08:04 -0500 (EST) (envelope-from ataraxia) Date: Mon, 25 Nov 2002 22:08:04 -0500 From: Ray Kohler To: freebsd-current@freebsd.org Cc: cg@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/pcm buffer.c channel.c feeder.c feeder_fmt.c feeder_rate.c sndstat.c sound.c sound.h vchan.c Message-ID: <20021126030804.GA52363@arkadia.nv.cox.net> Mail-Followup-To: freebsd-current@freebsd.org, cg@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > cg 2002/11/25 09:17:43 PST > > Modified files: > sys/dev/sound/pcm buffer.c channel.c feeder.c feeder_fmt.c > feeder_rate.c sndstat.c sound.c sound.h vchan.c > > Log: various fixes to eliminate locking warnings > > Approved by: re > Reviewed by: orion I have no idea why, but this commit broke kernel building: cc -c -O -pipe -mcpu=athlon -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/dev -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/ipfilter -D_KERNEL -include opt_global.h -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/dev/sound/isa/ad1816.c cc1: warnings being treated as errors /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock': /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' pointer /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in something not a structure or union /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock': /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' pointer /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in something not a structure or union *** Error code 1 And the same result for other consumers of snd_mtx* . -- Ray Kohler What color is a chameleon on a mirror? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message