From owner-cvs-all  Mon Nov  4  3:31:17 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9FFE337B401; Mon,  4 Nov 2002 03:31:15 -0800 (PST)
Received: from blues.jpj.net (blues.jpj.net [208.210.80.156])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DB9B043E3B; Mon,  4 Nov 2002 03:31:14 -0800 (PST)
	(envelope-from trevor@jpj.net)
Received: from blues.jpj.net (localhost.jpj.net [127.0.0.1])
	by blues.jpj.net (8.12.3/8.12.3) with ESMTP id gA4BVEV3054919;
	Mon, 4 Nov 2002 06:31:14 -0500 (EST)
	(envelope-from trevor@jpj.net)
Received: from localhost (trevor@localhost)
	by blues.jpj.net (8.12.3/8.12.3/Submit) with ESMTP id gA4BVEsM054916;
	Mon, 4 Nov 2002 06:31:14 -0500 (EST)
X-Authentication-Warning: blues.jpj.net: trevor owned process doing -bs
Date: Mon, 4 Nov 2002 06:31:14 -0500 (EST)
From: Trevor Johnson <trevor@jpj.net>
To: Kris Kennaway <kris@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>,
	Eric Melville <eric@FreeBSD.org>, Akinori Musha <knu@FreeBSD.org>,
	<ports@FreeBSD.org>
Subject: Re: cvs commit: ports/Mk bsd.port.mk
In-Reply-To: <20021103223004.GB25257@xor.obsecurity.org>
Message-ID: <20021104062332.M50593-100000@blues.jpj.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Kris Kennaway wrote:

> On Sun, Nov 03, 2002 at 09:27:28AM -0500, Trevor Johnson wrote:
[Kris wrote]
> > >   * If the ${COMMENT} file does not exist, use the value of the
> > >     ${PORTCOMMENT} variable instead.  This will allow us to incrementally
> > >     phase out pkg-comment [1]
[...]
> > 	PORTCOMMENT=""
> >
> > leaves only 66 for the comment itself, unless a continuation card is
> > used.  NetBSD and OpenBSD have chosen the
> > shorter name COMMENT instead.  That leaves 70 columns for the comment.
> > Our portlint recommends 70 (or fewer columns), so existing ports which
> > pass portlint are already consistent with the shorter name, but not
> > necessarily with the longer one.
[...]
> The problem with using COMMENT is that a number of ports already
> override it, so this patch breaks them.

A revised patch--untested--is at
<URL:http://people.freebsd.org/~trevor/ports/comment.diff>.
-- 
Trevor Johnson


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message