Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Sep 2012 18:17:39 +0400
From:      Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To:        Dmitry Sivachenko <demon@FreeBSD.org>
Cc:        python@freebsd.org, Chris Rees <utisoft@gmail.com>
Subject:   Re: bin/python3 symlink for python3X ports
Message-ID:  <50630E83.7070102@yandex.ru>
In-Reply-To: <5062E478.8020000@FreeBSD.org>
References:  <5062AAEA.4000401@FreeBSD.org> <CADLo838ZysqxVHPuj6_M223ohanPWRoqc2mwePNeBYbGa2OfRQ@mail.gmail.com> <5062C5CB.4060109@yandex.ru> <5062C769.6090305@FreeBSD.org> <5062C8CE.701@yandex.ru> <5062E478.8020000@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Dmitry Sivachenko wrote on 26.09.2012 15:18:
> On 26.09.2012 13:20, Ruslan Mahmatkhanov wrote:
>> Dmitry Sivachenko wrote on 26.09.2012 13:14:
>>> I don't have a patch but I can make one if you like.
>>
>> Please do.
>>
>
> Please consider the attached patch.

The patch seems good to me. The only thing: I'd rather define 
${PYTHON_MAJOR} (or ${PYTHON_MAJOR_VER}) in bsd.python.mk to make it 
reusable when USE_PYTHON is used (sorry for the pun).

PYTHON_MAJOR_VER=    ${PYTHON_VER:R}

because there will be other ports that need it. And as Li-Wen said, 
there should be the same change for python2. And it needs an exp-run, I 
believe.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50630E83.7070102>