From owner-p4-projects  Thu Mar 13  7:44:18 2003
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C889837B404; Thu, 13 Mar 2003 07:44:15 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5F00937B405
	for <perforce@freebsd.org>; Thu, 13 Mar 2003 07:44:15 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0AF4843F3F
	for <perforce@freebsd.org>; Thu, 13 Mar 2003 07:44:15 -0800 (PST)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h2DFiE0U055846
	for <perforce@freebsd.org>; Thu, 13 Mar 2003 07:44:14 -0800 (PST)
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h2DFiEIY055843
	for perforce@freebsd.org; Thu, 13 Mar 2003 07:44:14 -0800 (PST)
Date: Thu, 13 Mar 2003 07:44:14 -0800 (PST)
Message-Id: <200303131544.h2DFiEIY055843@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
Subject: PERFORCE change 26837 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=26837

Change 26837 by jhb@jhb_laptop on 2003/03/13 07:44:12

	Replace magic numbers with masks of the actual fields.

Affected files ...

.. //depot/projects/smpng/sys/i386/i386/mp_machdep.c#41 edit

Differences ...

==== //depot/projects/smpng/sys/i386/i386/mp_machdep.c#41 (text+ko) ====

@@ -2258,14 +2258,16 @@
 
 	/* do an INIT IPI: assert RESET */
 	icr_lo = lapic.icr_lo & APIC_ICRLO_RESV_MASK;
-	lapic.icr_lo = icr_lo | 0x00004500;
+	lapic.icr_lo = icr_lo | APIC_DEST_DESTFLD | APIC_TRIGMOD_EDGE |
+	    APIC_LEVEL_ASSERT | APIC_DESTMODE_PHY | APIC_DELMODE_INIT;
 
 	/* wait for pending status end */
 	while (lapic.icr_lo & APIC_DELSTAT_MASK)
 		 /* spin */ ;
 
 	/* do an INIT IPI: deassert RESET */
-	lapic.icr_lo = icr_lo | 0x000c8500;
+	lapic.icr_lo = icr_lo | APIC_DEST_ALLESELF | APIC_TRIGMOD_LEVEL |
+	    APIC_LEVEL_DEASSERT | APIC_DESTMODE_PHY | APIC_DELMODE_INIT;
 
 	/* wait for pending status end */
 	u_sleep(10000);		/* wait ~10mS */

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message