From owner-cvs-src@FreeBSD.ORG Tue May 17 17:07:07 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A0BE16A4E1; Tue, 17 May 2005 17:07:07 +0000 (GMT) Received: from mailbox8.ucsd.edu (mailbox8.ucsd.edu [132.239.1.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id C32AC43D97; Tue, 17 May 2005 17:07:06 +0000 (GMT) (envelope-from okumoto@ucsd.edu) Received: from smtp.ucsd.edu (smtp-a.ucsd.edu [132.239.1.49]) by mailbox8.ucsd.edu (8.13.3/8.13.3) with ESMTP id j4HH6v8c028042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 17 May 2005 10:06:57 -0700 (PDT) Received: from ucsd.edu (adsl-63-199-247-178.dsl.sndg02.pacbell.net [63.199.247.178]) by smtp.ucsd.edu (8.12.10/8.9.3) with ESMTP id j4HH6sTg016058; Tue, 17 May 2005 10:06:56 -0700 (PDT) Message-ID: <428A24AE.2050207@ucsd.edu> Date: Tue, 17 May 2005 10:06:54 -0700 From: Max Okumoto User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20030824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Harti Brandt References: <200505121545.j4CFjENu078768@repoman.freebsd.org> <20050517144446.gibxprydoosokw0k@netchild.homeip.net> <20050517164720.O7468@beagle.kn.op.dlr.de> In-Reply-To: <20050517164720.O7468@beagle.kn.op.dlr.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Greylisting: NO DELAY (Trusted relay host); processed by UCSD_GL-v1.2 on mailbox8.ucsd.edu; Tue, 17 May 2005 10:06:57 -0700 (PDT) X-MailScanner: PASSED (v1.2.8 4025 j4HH6v8c028042 mailbox8.ucsd.edu) cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.bin/make job.c##SPAM X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2005 17:07:07 -0000 Harti Brandt wrote: > On Tue, 17 May 2005, Alexander Leidinger wrote: > > AL>Max Okumoto wrote: > AL> > AL>> If I use mkdtemp(), there is a chance that someone with the > AL>> same UID could race to build the fifo. Do we care about > AL>> races with ourselves? Or am I just being toooo paranoid? :-) > AL> > AL>Are you sure? mkdtemp() generates a "random" name like mkstemp() does, so the > AL>race would have existed already before (but the probability is very low that > AL>two make instances generate the same name)... > > Yes, I think the race existed before. That's why I put the somewhat fuzzy > security statement into the commit log. I put it so fuzzy, because I'm not > sure we should worry about this. The only thing that could happen is a > kind of DoS attack from a program running under your UID (it could steal > you tokens or insert an unlimited number of tokens) on your make run. This > seems actually not a something to worry about. > > harti They can't add tokens, mkfifo() will fail with EEXITS. Max