Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Mar 2003 07:44:14 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 26837 for review
Message-ID:  <200303131544.h2DFiEIY055843@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=26837

Change 26837 by jhb@jhb_laptop on 2003/03/13 07:44:12

	Replace magic numbers with masks of the actual fields.

Affected files ...

.. //depot/projects/smpng/sys/i386/i386/mp_machdep.c#41 edit

Differences ...

==== //depot/projects/smpng/sys/i386/i386/mp_machdep.c#41 (text+ko) ====

@@ -2258,14 +2258,16 @@
 
 	/* do an INIT IPI: assert RESET */
 	icr_lo = lapic.icr_lo & APIC_ICRLO_RESV_MASK;
-	lapic.icr_lo = icr_lo | 0x00004500;
+	lapic.icr_lo = icr_lo | APIC_DEST_DESTFLD | APIC_TRIGMOD_EDGE |
+	    APIC_LEVEL_ASSERT | APIC_DESTMODE_PHY | APIC_DELMODE_INIT;
 
 	/* wait for pending status end */
 	while (lapic.icr_lo & APIC_DELSTAT_MASK)
 		 /* spin */ ;
 
 	/* do an INIT IPI: deassert RESET */
-	lapic.icr_lo = icr_lo | 0x000c8500;
+	lapic.icr_lo = icr_lo | APIC_DEST_ALLESELF | APIC_TRIGMOD_LEVEL |
+	    APIC_LEVEL_DEASSERT | APIC_DESTMODE_PHY | APIC_DELMODE_INIT;
 
 	/* wait for pending status end */
 	u_sleep(10000);		/* wait ~10mS */

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303131544.h2DFiEIY055843>