From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct  6 13:42:42 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 176A016A4B3
	for <freebsd-bugs@freebsd.org>; Mon,  6 Oct 2003 13:42:42 -0700 (PDT)
Received: from lewis.lclark.edu (paclaw.org [149.175.1.5])
	by mx1.FreeBSD.org (Postfix) with SMTP id 7091D43F75
	for <freebsd-bugs@freebsd.org>; Mon,  6 Oct 2003 13:42:41 -0700 (PDT)
	(envelope-from eta@lclark.edu)
Received: from [149.175.34.250] ([149.175.34.250])
 by lewis.lclark.edu (SAVSMTP 3.1.1.32) with SMTP id M2003100613422825234
 ; Mon, 06 Oct 2003 13:42:28 -0700
From: Eric Anholt <eta@lclark.edu>
To: Bruce Evans <bde@zeta.org.au>
In-Reply-To: <20031006232811.D9454@gamplex.bde.org>
References: <200310020933.h929XI8r028284@freefall.freebsd.org>
	 <3131.62.78.135.6.1065426014.squirrel@office.mawit.com>
	 <20031006232811.D9454@gamplex.bde.org>
Content-Type: text/plain
Message-Id: <1065472947.637.1.camel@leguin>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 06 Oct 2003 13:42:27 -0700
Content-Transfer-Encoding: 7bit
cc: freebsd-bugs@freebsd.org
cc: "Jukka A. Ukkonen" <jau@mawit.com>
Subject: Re: Minor change to silence complaints from cpp
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2003 20:42:42 -0000

On Mon, 2003-10-06 at 06:41, Bruce Evans wrote:
> On Mon, 6 Oct 2003, Jukka A. Ukkonen wrote:
> 
> > E.g. when compiling X-server cpp has been complaining about
> > _POSIX_C_SOURCE not being defined. This was easily silenced
> > with the following minor change...
> 
> This seems to be a bug or a feature in the X server's Makefile.  It
> apparently uses -Wundef to generate warnings about the Standard C
> feature of undefined identifiers having value 0 in cpp expressions.
> 
> > --- /usr/include/sys/cdefs.h.orig	Mon Oct  6 10:26:47 2003
> > +++ /usr/include/sys/cdefs.h	Mon Oct  6 10:28:06 2003
> > @@ -270,13 +270,13 @@
> >   */
> >
> >  /* Deal with IEEE Std. 1003.1-1990, in which _POSIX_C_SOURCE == 1. */
> > -#if _POSIX_C_SOURCE == 1
> > +#if defined(_POSIX_C_SOURCE) && (_POSIX_C_SOURCE == 1)
> >  #undef _POSIX_C_SOURCE		/* Probably illegal, but beyond caring now. */
> >  #define	_POSIX_C_SOURCE		199009
> >  #endif
> >
> >  /* Deal with IEEE Std. 1003.2-1992, in which _POSIX_C_SOURCE == 2. */
> > -#if _POSIX_C_SOURCE == 2
> > +#if defined(_POSIX_C_SOURCE) && (_POSIX_C_SOURCE == 2)
> >  #undef _POSIX_C_SOURCE
> >  #define	_POSIX_C_SOURCE		199209
> >  #endif
> 
> I'd prefer not to uglify the system headers to support -Wundef.
> 
> Most warnings in system headers including ones from -Wundef can be
> suppressed using -Wno-system-headers.  -Wno-system-headers is the FSF
> default but FreeBSD reverses this.

XFree86-4-Server-snap and XFree86 upstream have been patched to use
-Wno-system-headers with gcc3 so we can avoid this noise.  Doesn't help
on -stable, though.

-- 
Eric Anholt                                eta@lclark.edu          
http://people.freebsd.org/~anholt/         anholt@FreeBSD.org