Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Dec 2011 02:42:53 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r228727 - head/sys/dev/sound/pci/hda
Message-ID:  <201112200242.pBK2grrM087468@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Tue Dec 20 02:42:53 2011
New Revision: 228727
URL: http://svn.freebsd.org/changeset/base/228727

Log:
  Oops, list of IDs is not sequential. Have to list all of them expoicitly.

Modified:
  head/sys/dev/sound/pci/hda/hdac.c

Modified: head/sys/dev/sound/pci/hda/hdac.c
==============================================================================
--- head/sys/dev/sound/pci/hda/hdac.c	Tue Dec 20 02:00:27 2011	(r228726)
+++ head/sys/dev/sound/pci/hda/hdac.c	Tue Dec 20 02:42:53 2011	(r228727)
@@ -6491,15 +6491,23 @@ hdac_audio_commit(struct hdac_devinfo *d
 	if (sc->pci_subvendor == APPLE_INTEL_MAC)
 		hdac_command(sc, HDA_CMD_12BIT(cad, devinfo->nid,
 		    0x7e7, 0), cad);
-	/* Cast some spells for VIA VT1708S. */
 	id = hdac_codec_id(devinfo->codec);
-	if (id >= HDA_CODEC_VT1708S_0 && id <= HDA_CODEC_VT1708S_7) {
+	switch (id) {
+	case HDA_CODEC_VT1708S_0:
+	case HDA_CODEC_VT1708S_1:
+	case HDA_CODEC_VT1708S_2:
+	case HDA_CODEC_VT1708S_3:
+	case HDA_CODEC_VT1708S_4:
+	case HDA_CODEC_VT1708S_5:
+	case HDA_CODEC_VT1708S_6:
+	case HDA_CODEC_VT1708S_7:
 		/* Enable Mic Boost Volume controls. */
 		hdac_command(sc, HDA_CMD_12BIT(cad, devinfo->nid,
 		    0xf98, 0x01), cad);
 		/* Don't bypass mixer. */
 		hdac_command(sc, HDA_CMD_12BIT(cad, devinfo->nid,
 		    0xf88, 0xc0), cad);
+		break;
 	}
 
 	/* Commit controls. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112200242.pBK2grrM087468>