From owner-svn-ports-all@freebsd.org Thu Jan 2 20:13:11 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C02001D8EE7; Thu, 2 Jan 2020 20:13:11 +0000 (UTC) (envelope-from adridg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47pfNl4fLDz3NX8; Thu, 2 Jan 2020 20:13:11 +0000 (UTC) (envelope-from adridg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9AA9E20CA9; Thu, 2 Jan 2020 20:13:11 +0000 (UTC) (envelope-from adridg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 002KDBJX030913; Thu, 2 Jan 2020 20:13:11 GMT (envelope-from adridg@FreeBSD.org) Received: (from adridg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 002KDBTO030912; Thu, 2 Jan 2020 20:13:11 GMT (envelope-from adridg@FreeBSD.org) Message-Id: <202001022013.002KDBTO030912@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adridg set sender to adridg@FreeBSD.org using -f From: Adriaan de Groot Date: Thu, 2 Jan 2020 20:13:11 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r521876 - head/Mk/Uses X-SVN-Group: ports-head X-SVN-Commit-Author: adridg X-SVN-Commit-Paths: head/Mk/Uses X-SVN-Commit-Revision: 521876 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 20:13:11 -0000 Author: adridg Date: Thu Jan 2 20:13:11 2020 New Revision: 521876 URL: https://svnweb.freebsd.org/changeset/ports/521876 Log: Fix up file permissions in Qt ports. Because qt-dist.mk sets EXTRACT_AFTER_ARGS, the framework-standard --no-same-owner and --no-same-permissions aren't added. That means that the files end up in packages with the permissions from the tarball, and in particular that official packages contain group-writable (wheel) includes (C++ headers) and other files. This was reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227027 and fixed in 465911 (18 months ago) but the move from bsd.qt.mk to Uses/qt-dist.mk lost those settings again. Re-add them to the Uses/ file to improve package security. (The problem does not seem to be present in my local poudriere builds) PR: 227027 Reported by: grarpamp@gmail.com Reviewed by: tcberner Approved by: tcberner MFH: 2020Q1 Differential Revision: https://reviews.freebsd.org/D22999 Modified: head/Mk/Uses/qt-dist.mk Modified: head/Mk/Uses/qt-dist.mk ============================================================================== --- head/Mk/Uses/qt-dist.mk Thu Jan 2 20:03:35 2020 (r521875) +++ head/Mk/Uses/qt-dist.mk Thu Jan 2 20:13:11 2020 (r521876) @@ -112,7 +112,8 @@ EXTRACT_SUFX?= .tar.xz # Other ports from other Qt modules will automatically build examples and # tests if the directories exist because of mkspecs/features/qt_parts.prf. EXTRACT_AFTER_ARGS?= ${DISTNAME:S,$,/examples,:S,^,--exclude ,} \ - ${DISTNAME:S,$,/tests,:S,^,--exclude ,} + ${DISTNAME:S,$,/tests,:S,^,--exclude ,} \ + --no-same-owner --no-same-permissions . endif # ! ${_QT_VER:M5} CONFIGURE_ENV+= MAKE="${MAKE:T}"