From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 09:04:29 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0BFAE2AD; Mon, 16 Feb 2015 09:04:29 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A148B7BC; Mon, 16 Feb 2015 09:04:28 +0000 (UTC) Received: from moby.local ([92.75.152.244]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LaXEN-1XihZy2fs7-00mJ6m; Mon, 16 Feb 2015 09:59:09 +0100 Message-ID: <54E1B14E.10707@gmx.com> Date: Mon, 16 Feb 2015 09:58:54 +0100 From: Nikos Vassiliadis User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Craig Rodrigues , Gleb Smirnoff Subject: Re: svn commit: r276747 - head/sys/netpfil/pf References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> <20150215190100.GQ15484@FreeBSD.org> <20150216012528.GA15484@FreeBSD.org> <20150216074656.GE15484@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:IulhHcdbDZLKisuDEwhlb5r617tFzQuMRJNU1qRrtzMsBhunNc8 Rmo5ITalTChzfX/Sjze+vYi0c/WcJBIfG1ny/CQ19PgnXS17p+HQgPILDwDqDvWy8H9IKBY KQMz/8JXdcyKW/685YYlKDOcGwTUK9jkxik8XLpGr6VrKHu8Y/gJyNGCGCblIPRvL5vgu6Z /TmRBjok1+80Bj+AUX9bA== X-UI-Out-Filterresults: notjunk:1; Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 09:04:29 -0000 Hi Gleb & Craig, I am already working on the issues that need to be fixed, namely: 1) all the changes from projects/pf 2) unloading the module 3) one purge thread per pf instance will remain until we have more experience It's almost ready, I am trying to fix unloading the module. As I am not at home this week I will send you a patch for review on Monday. Best regards, Nikos On 02/16/15 09:02, Craig Rodrigues wrote: > On Sun, Feb 15, 2015 at 11:46 PM, Gleb Smirnoff wrote: > >> On Sun, Feb 15, 2015 at 11:36:17PM -0800, Craig Rodrigues wrote: >> C> On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff >> wrote: >> C> >> C> > On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: >> C> > C> By the way, it would be helpful if you could provide feedback in >> C> > C> Phabricator. When I created those Phabricator reviews, I added >> C> > C> you as a reviewer to all of them, so you can't say that you didn't >> see >> C> > C> the patches. >> C> > C> You did not provide feedback on any of them: >> C> > C> >> C> > C> https://reviews.freebsd.org/D1309 >> C> > C> https://reviews.freebsd.org/D1312 >> C> > C> https://reviews.freebsd.org/D1313 >> C> > C> https://reviews.freebsd.org/D1315 >> C> > C> >> C> > C> Please take some time to go and provide feedback in those >> C> > C> reviews, so that a better patch can be made that makes you happy. >> C> > >> C> > Did you address all problems that arised after code was committed? >> C> > >> C> > Please do, otherwise my review would require me to cut-n-paste from >> C> > my own emails. >> C> > >> C> >> C> Yes, please cut and paste from your e-mails, and put in the reviews. >> >> No, I will not do this. You know right now that you have problems >> in the aforementioned phab URLs, and you are asking me to look at >> patches at to point them out to you. This is your task, not mine. >> >> Please address all already known problems and update the phab revisions. >> >> C> It's easier to follow in the individual reviews because there are >> different >> C> changes >> C> in each review, rather than one big revert, which is what you did. >> >> I'm already starting to repeat myself. I did a big revert, because >> the first change wasn't compilable, later changes fixed compilation >> failures, but introduced unacceptable bugs. That's why I was forced >> to back out all chain. >> > > > > It's not clear to me what parts you find unacceptable, > and what parts you find acceptable. I added you to the reviews > in Phabricator from the beginning, so it would have been nice if you could > have > provided the review feedback there. Since you are slow to provide > feedback when I asked you to be a reviewer in Phabricator, but you > are quick to revert changes, and provide unclear feedback during your > reversion, > this makes it very hard to make forward progress in this area. > > In the past, multiple like Nikos and Martin Matuska have been providing > patches in your > projects/pf branch, but you don't seem to have the time/interest to push > these patches back into head. > I've seen that Martin Matuska stopped waiting for you to merge the pf > branch to head, and started cherry > > -- > Craig >