From owner-cvs-all Tue Nov 28 8:14: 2 2000 Delivered-To: cvs-all@freebsd.org Received: from mass.osd.bsdi.com (adsl-63-202-177-187.dsl.snfc21.pacbell.net [63.202.177.187]) by hub.freebsd.org (Postfix) with ESMTP id EA05437B401; Tue, 28 Nov 2000 08:13:58 -0800 (PST) Received: from mass.osd.bsdi.com (localhost [127.0.0.1]) by mass.osd.bsdi.com (8.11.0/8.11.1) with ESMTP id eASGLLF25331; Tue, 28 Nov 2000 08:21:24 -0800 (PST) (envelope-from msmith@mass.osd.bsdi.com) Message-Id: <200011281621.eASGLLF25331@mass.osd.bsdi.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Garrett Wollman Cc: "Matthew N. Dodd" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mlx mlx.c mlx_pci.c mlxvar.h In-reply-to: Your message of "Tue, 28 Nov 2000 10:26:23 EST." <200011281526.KAA06325@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 28 Nov 2000 08:21:21 -0800 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > < said: > > > Avoid hardcoding the 'rid' and 'type' of the MEM/IOPORT resource. > > Store the 'rid' and 'type' in the softc and use them in mlx.c:mlx_free(). > > > EISA and MCA front ends will require this. > > FYI.... I've been thinking about changes to the resource management > portion of the bus interface, and one of the changes that I'm > contemplating is passing resource IDs by value rather than by > address. This is one of the quirks of new-bus that I've had the most > negative feedback on. Do you want to clarify what you mean by "by value"? If you mean having a device say "give me the I/O resource that's 32 bytes long", then definitely not. A search interface would be OK, but having bus-specific semi-opaque RIDs is actually not a bad thing. In the PCI case, most often the documentation for a device will *only* tell you the BAR address, so you don't have anything else to go on. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message