From owner-svn-src-stable@freebsd.org Mon Mar 26 22:15:42 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF0F7F70583; Mon, 26 Mar 2018 22:15:42 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F52877977; Mon, 26 Mar 2018 22:15:42 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A84972602E6; Tue, 27 Mar 2018 00:15:40 +0200 (CEST) Subject: Re: svn commit: r331591 - stable/11/sys/dev/mlx5/mlx5_core To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org References: <201803262106.w2QL6Ngg037236@repo.freebsd.org> <8910480.84UKvZQndd@ralph.baldwin.cx> From: Hans Petter Selasky Message-ID: <822e108c-160f-80b1-eedc-d5221f0b300d@selasky.org> Date: Tue, 27 Mar 2018 00:15:33 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8910480.84UKvZQndd@ralph.baldwin.cx> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 22:15:42 -0000 On 03/27/18 00:04, John Baldwin wrote: > On Monday, March 26, 2018 09:06:23 PM Hans Petter Selasky wrote: >> Author: hselasky >> Date: Mon Mar 26 21:06:23 2018 >> New Revision: 331591 >> URL: https://svnweb.freebsd.org/changeset/base/331591 >> >> Log: >> MFC r330660: >> Add call to setup firmware data dump structure during device load in >> mlx5core. >> >> Do not consider the inability to create a firmware dump fatal, but >> inform about the situation and allow the driver to attach. The device >> might not implement the needed VSC, or we might not know the layout of >> the registers map. In either case, only firmware dump functionality is >> limited, the network operations should be fine. >> >> Submitted by: kib@ >> Sponsored by: Mellanox Technologies > > Please batch up MFC commits at least enough to ensure they compile. We > really should not be breaking the build on stable branches. If you are > merging a commit that required followup fixes in head, the MFC needs to > include those followup fixes. > > I'm getting this failure on a tree at this revision: > > /usr/src/usr.sbin/mlx5tool/mlx5tool.c:31:10: fatal error: 'dev/mlx5/mlx5io.h' file not found > #include > ^~~~~~~~~~~~~~~~~~~ > 1 error generated. > --- mlx5tool.o --- > *** [mlx5tool.o] Error code 1 > Hi, All the bits and pieces needed are part of: https://svnweb.freebsd.org/changeset/base/331586 I'll dig into it. > See also: > > https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-build/2930/console > --HPS