From owner-cvs-all@FreeBSD.ORG  Mon May 19 20:25:27 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 353CB1065676;
	Mon, 19 May 2008 20:25:27 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id D6F568FC24;
	Mon, 19 May 2008 20:25:26 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id D830967F842;
	Mon, 19 May 2008 22:24:48 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id yYTyBf7EA1ZN; Mon, 19 May 2008 22:24:46 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 552EE67F82D;
	Mon, 19 May 2008 22:24:46 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id m4JKOkMC082738;
	Mon, 19 May 2008 22:24:46 +0200 (CEST) (envelope-from rdivacky)
Date: Mon, 19 May 2008 22:24:45 +0200
From: Roman Divacky <rdivacky@FreeBSD.org>
To: John Birrell <jb@FreeBSD.org>
Message-ID: <20080519202445.GA82705@freebsd.org>
References: <200805181932.m4IJWagN055358@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200805181932.m4IJWagN055358@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_sdt.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 May 2008 20:25:27 -0000

On Sun, May 18, 2008 at 07:32:36PM +0000, John Birrell wrote:
> jb          2008-05-18 19:32:36 UTC
> 
>   FreeBSD src repository
> 
>   Added files:
>     sys/kern             kern_sdt.c 
>   Log:
>   Add kernel support for the Statically Defined Trace provider.
>   
>   This is BSD licensed code written specifically for FreeBSD.
>   
>   It initialises using SYSINIT so that the SDT provider, probe and
>   argument description linkage is done whenever a module is loaded,
>   regardless of whether the DTrace modules are loaded or not.
>   
>   This file is optionally compiled into the kernel if the KDTRACE_HOOKS
>   option is defined.

great to see this coming!

in the sdt_*_listall() functions you lock the sx lock exclusively while
traversing the list... why? I think shared locking is enough in those
cases....

thnx!

roman