From owner-svn-src-head@freebsd.org Tue Sep 3 14:06:47 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B9007DCF19; Tue, 3 Sep 2019 14:06:46 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zp1rSvz4PtR; Tue, 3 Sep 2019 14:06:46 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id EC68A1AB52; Tue, 3 Sep 2019 14:06:16 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id BEDC41527E; Fri, 12 Apr 2019 15:30:20 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F5C477F25; Fri, 12 Apr 2019 15:30:20 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 1231015254; Fri, 12 Apr 2019 15:30:20 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 7D1B315251; Fri, 12 Apr 2019 15:30:17 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2013577F1F; Fri, 12 Apr 2019 15:30:16 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-ot1-f47.google.com with SMTP id d24so8703016otl.11; Fri, 12 Apr 2019 08:30:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bwp9OI+PryeC3EcGPyQ0PgZsrrXnl2dGeRy67DQHpic=; b=OwnB6xJmEfy+3wbJ15CI60j6TNBholbJllTrCqUdIdCCl9VulESgMo6sXBZ9gZTZEF uFLdHZ7xpQjx87QDVUN9EaGlpC/iK7e/4kQ/4WWW69lSrAfC68J0Bhcv0ybMBs8QAoGK w+euKDRGqakBK+87NHwVkK6sP4E9SeswERrFR1+5hWP9usUUWGYmWon/F7ot9xPu0P0+ 9rkRTLBRgUiZnESS0iEeXaTHNgHpJUoaFEupP+AUkOB8UejYaLZFy96Y6g5rfpVGaDFe X9/9il7ppYF97R9JhQ1waSYvNY0tNmgV8xUR4ylnpUu0mI19Ual//cbbOK8bWW163J/m ezOA== X-Gm-Message-State: APjAAAV6pswsykzKXTBXQBD/R9WcjeSdan5aNsV8glx0anbzzS5xXYpa b+O2aZqyenQmrBcpNwa+IscYZqBtjz73mPKrSRw= X-Google-Smtp-Source: APXvYqx0xzJWVnnam48qekdL5Qu6An59iXF166Zu8S2wh8CpVMlgoGQKU1jJp6qHfxU1tDGkVaJxwzbu22/ozuv8djs= X-Received: by 2002:a9d:27e9:: with SMTP id c96mr37823246otb.206.1555082626454; Fri, 12 Apr 2019 08:23:46 -0700 (PDT) MIME-Version: 1.0 References: <201904111121.x3BBLj2K023087@repo.freebsd.org> <20190412151958.GB1923@kib.kiev.ua> In-Reply-To: <20190412151958.GB1923@kib.kiev.ua> From: Edward Napierala Message-ID: Subject: Re: svn commit: r346120 - head/sys/kern To: Konstantin Belousov Cc: Conrad Meyer , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 3F5C477F25 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:47 -0000 X-Original-Date: Fri, 12 Apr 2019 16:23:35 +0100 X-List-Received-Date: Tue, 03 Sep 2019 14:06:47 -0000 On Fri, 12 Apr 2019 at 16:20, Konstantin Belousov wrote: > > On Fri, Apr 12, 2019 at 03:28:26PM +0100, Edward Napierala wrote: > > On Thu, 11 Apr 2019 at 17:26, Conrad Meyer wrote: > > > > > > Hi Edward, > > > > > > I have a question about this change below. > > > > > > On Thu, Apr 11, 2019 at 4:22 AM Edward Tomasz Napierala > > > wrote: > > > > > > > > Author: trasz > > > > Date: Thu Apr 11 11:21:45 2019 > > > > New Revision: 346120 > > > > URL: https://svnweb.freebsd.org/changeset/base/346120 > > > > > > > > Log: > > > > Use shared vnode locks for the ELF interpreter. > > > > [..] > > > > > On the one hand, perhaps VOP_IS_TEXT() is rarely false for common > > > interpreters anyway. On the other hand, there is sort of a > > > renaissance of static linking happening. So maybe the thought is, > > > !VOP_IS_TEXT is likely to be rare, and LK_UPGRADE success even more > > > rare, so why bother writing additional code for it? > > > > Konstantin already answered to most of the points, but regarding > > this one: that's exactly the case. In a typical case, the number of times > > this code path will be executed is zero. I'd expect one - when running > > dynamically linked ELF binary for the first time - but for some reason in > > that case lookup() returns with the exclusive vnode lock already held. > > This is strange. Which filesystem do you use ? UFS.