From owner-cvs-src@FreeBSD.ORG  Thu Mar 29 01:52:14 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 625AA16A400;
	Thu, 29 Mar 2007 01:52:14 +0000 (UTC)
	(envelope-from thompsa@freebsd.org)
Received: from heff.fud.org.nz (203-109-251-39.static.bliink.ihug.co.nz
	[203.109.251.39])
	by mx1.freebsd.org (Postfix) with ESMTP id F341113C46C;
	Thu, 29 Mar 2007 01:52:13 +0000 (UTC)
	(envelope-from thompsa@freebsd.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id 85D261CC58; Thu, 29 Mar 2007 13:52:12 +1200 (NZST)
Date: Thu, 29 Mar 2007 13:52:12 +1200
From: Andrew Thompson <thompsa@freebsd.org>
To: Greg 'groggy' Lehey <grog@FreeBSD.org>
Message-ID: <20070329015212.GA97061@heff.fud.org.nz>
References: <200703282125.l2SLPuR9058727@repoman.freebsd.org>
	<20070329012834.GC79742@wantadilla.lemis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070329012834.GC79742@wantadilla.lemis.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Maksim Yevmenkin <emax@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: Giving in to Coverity (was: cvs commit:
	src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2007 01:52:14 -0000

On Thu, Mar 29, 2007 at 10:58:34AM +0930, Greg 'groggy' Lehey wrote:
> On Wednesday, 28 March 2007 at 21:25:56 +0000, Maksim Yevmenkin wrote:
> > emax        2007-03-28 21:25:56 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c
> >   Log:
> >   Try to silence Coverity by adding (void) in front of function call.
> >   Also add a comment, explaining why return value is not being checked.
> 
> I hope Coverity isn't going to force us to add unnecessary casts to
> function calls.

Well no, you can always silence Coverity by just marking it as a false
bug.


Andrew