From owner-p4-projects@FreeBSD.ORG  Fri Jul  2 00:21:56 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3F1C61065676; Fri,  2 Jul 2010 00:21:56 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 022FB1065670
	for <perforce@FreeBSD.org>; Fri,  2 Jul 2010 00:21:56 +0000 (UTC)
	(envelope-from bfiedler@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id CAE8B8FC2D
	for <perforce@FreeBSD.org>; Fri,  2 Jul 2010 00:21:55 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o620LthU000672
	for <perforce@FreeBSD.org>; Fri, 2 Jul 2010 00:21:55 GMT
	(envelope-from bfiedler@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o620LtdW000670
	for perforce@freebsd.org; Fri, 2 Jul 2010 00:21:55 GMT
	(envelope-from bfiedler@FreeBSD.org)
Date: Fri, 2 Jul 2010 00:21:55 GMT
Message-Id: <201007020021.o620LtdW000670@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bfiedler@FreeBSD.org using -f
From: Benjamin Fiedler <bfiedler@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 180399 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Jul 2010 00:21:56 -0000

http://p4web.freebsd.org/@@180399?ac=10

Change 180399 by bfiedler@freebsd-7803 on 2010/07/02 00:21:46

	Fix bugs in strrep()

Affected files ...

.. //depot/projects/soc2010/bsdtextproc/gabor_diff/diff.c#8 edit
.. //depot/projects/soc2010/bsdtextproc/gabor_diff/diffreg.c#9 edit

Differences ...

==== //depot/projects/soc2010/bsdtextproc/gabor_diff/diff.c#8 (text+ko) ====


==== //depot/projects/soc2010/bsdtextproc/gabor_diff/diffreg.c#9 (text+ko) ====

@@ -1573,12 +1573,12 @@
 
 /*
  * Replaces all occurences of substring 'old' with substring 'new',
- * realloc()'ing base ptr as necessary
+ * realloc()'ing base ptr if more characters necessary
  */
 char *
 strrep(char *base, char *old, char *new)
 {
-        char    *ptr, *tmp, *end;
+        char    *ptr, *tmp;
         int     occ, len1, len2, newlen;
 
         occ = 0;  
@@ -1592,45 +1592,36 @@
                 return base;
         }
 
-        while( (ptr = strstr(ptr, old)) )
+        for(; (ptr = strstr(ptr, old)); occ++ )
         {
-                occ++;   
                 ptr+=len1;
         }
 
-        if( occ == 0){
+        if( occ == 0)
+	{
                 return base;
         }
 
+        newlen = strlen(base) + occ * (len2 - len1);
 
-        newlen = strlen(base) + occ * (len2 - len1);
-        end = base + newlen -1;
         if( len2 > len1)
         {
-                base = realloc(base, sizeof(char) * newlen );
+                base = erealloc(base, sizeof(char) * newlen +1);
         }
 
-        tmp = malloc( sizeof(char) * strlen(base));
+        tmp = emalloc( sizeof(char) * strlen(base) +1);
 
-        if( len2 > 0 )
-	{
-        	len2 = 1;
-        }
-        for (ptr = base; (ptr = strstr(base, old)) != NULL; )
+        for (ptr = base; (ptr = strstr(ptr, old)) != NULL; )
         {
-                strncpy(tmp, ptr+len1, strlen(base) );
+                strncpy(tmp, ptr+len1, strlen(base)+1 );
                 strncpy(ptr, new, len2);
-                strncpy(ptr+len2, tmp, end - ptr );
-                ptr+=len2;
+                strncpy(ptr+len2, tmp, strlen(tmp)+1);
+                ptr+= len2 > 0 ? len2 : 1;
         }
 
-        if(len2 < len1)
-	{
-                *(end + occ*(len2 - len1) ) = '\0';
-        }
+	*(base + newlen) = '\0';
 
         free(tmp);
-
         return base;
 }