From owner-freebsd-stable@FreeBSD.ORG Wed Nov 1 20:08:30 2006 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8E8016A40F for ; Wed, 1 Nov 2006 20:08:30 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.174]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A1F543D49 for ; Wed, 1 Nov 2006 20:08:29 +0000 (GMT) (envelope-from uspoerlein@gmail.com) Received: by ug-out-1314.google.com with SMTP id m2so1558496uge for ; Wed, 01 Nov 2006 12:08:28 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to; b=uXupCjIIp/6+F/Qgb/qqiKQOJaYAwbkbp8TmHStst9b1nFBtkVGww3hkJw99Lf94jhUQM0QOuc8YAjreFhlFpv5JcTdeZ/kRVVBnNCbaxc7melungp1G+Xa5NJ5HhaAPpZuPRW5VXoYXnc2KynvSlNmBUzqptSl28m88xaUdl90= Received: by 10.67.91.6 with SMTP id t6mr8795953ugl; Wed, 01 Nov 2006 12:08:28 -0800 (PST) Received: from roadrunner.q.local ( [85.180.142.212]) by mx.google.com with ESMTP id 53sm1080357ugn.2006.11.01.12.08.28; Wed, 01 Nov 2006 12:08:28 -0800 (PST) Received: from roadrunner.q.local (localhost [127.0.0.1]) by roadrunner.q.local (8.13.8/8.13.8) with ESMTP id kA1K8KjR023936; Wed, 1 Nov 2006 21:08:20 +0100 (CET) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.q.local (8.13.8/8.13.8/Submit) id kA1K8JmF023935; Wed, 1 Nov 2006 21:08:19 +0100 (CET) (envelope-from uspoerlein@gmail.com) Date: Wed, 1 Nov 2006 21:08:19 +0100 From: Ulrich Spoerlein To: Kris Kennaway Message-ID: <20061101200819.GB1522@roadrunner.q.local> Mail-Followup-To: Kris Kennaway , stable@freebsd.org References: <7ad7ddd90610300741k5789f64j8f410b6e866b99ee@mail.gmail.com> <20061030224935.GA95120@xor.obsecurity.org> <7ad7ddd90610302348j6b7aabc7vc0a89e1e95d8fd27@mail.gmail.com> <20061031184150.GA27161@xor.obsecurity.org> <7ad7ddd90611010257o75546455p7da194b17037f8ed@mail.gmail.com> <20061101175428.GA33982@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061101175428.GA33982@xor.obsecurity.org> Cc: stable@freebsd.org Subject: Re: panic: vfs_getopt: caller passed 'opts' as NULL X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2006 20:08:30 -0000 Kris Kennaway wrote: > > Nullfs seems more fragile than I initially thought ... > > It's just that compiling in the extra debugging (it might be > DEBUG_LOCKS or DEBUG_VFS_LOCKS, I forget which), causes the sizes of > structures to change, so when the module tries to fondle the structure > at a certain offset thinking it's accessing a certain field, it's > really fondling something else entirely and the kernel gets a nasty > surprise and panics. It is DEBUG_LOCKS. The DEBUG_VFS_LOCKS macro only enables additional code at runtime, it does not alter the ABI. Ironically, it is even documented in conf/NOTES. For the future, I have to remember that nullfs is a module. Ulrich Spoerlein -- A: Yes. >Q: Are you sure? > >A: Because it reverses the logical flow of conversation. > >>Q: Why is top posting frowned upon?