From owner-cvs-src-old@FreeBSD.ORG Wed May 19 19:03:35 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25B601065678 for ; Wed, 19 May 2010 19:03:35 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EE6738FC17 for ; Wed, 19 May 2010 19:03:34 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4JJ3Yhi076486 for ; Wed, 19 May 2010 19:03:34 GMT (envelope-from dougb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4JJ3YIt076485 for cvs-src-old@freebsd.org; Wed, 19 May 2010 19:03:34 GMT (envelope-from dougb@repoman.freebsd.org) Message-Id: <201005191903.o4JJ3YIt076485@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to dougb@repoman.freebsd.org using -f From: Doug Barton Date: Wed, 19 May 2010 19:03:19 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d SERVERS ddb dumpon hostid hostid_save initrandom mdconfig mountcritlocal savecore sysctl zvol X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2010 19:03:35 -0000 dougb 2010-05-19 19:03:19 UTC FreeBSD src repository Modified files: etc/rc.d SERVERS ddb dumpon hostid hostid_save initrandom mdconfig mountcritlocal savecore sysctl zvol Log: SVN rev 208307 on 2010-05-19 19:03:19Z by dougb This change does the following for the scripts that run up through FILESYSTEMS (the default early_late_divider): 1. Move sysctl to run first 2. Move as many BEFOREs to REQUIREs as possible. 3. Minor effect, move hostid_save from right before mdconfig to right after. A lot of the early scripts make use of sysctl one way or another so running this first makes a lot of sense given that system-critical values are often placed in sysctl.conf. My original purpose for working on this was that while doing some debugging on other stuff I noticed that the order of execution was different in the first pass through the early scripts and the second. In practice that doesn't matter because the scripts are not executed the second time. However this _can_ result in problems if the difference in the rcorder moves a script from the late section to the early section in the second pass (which would mean the script would not get executed). So, I wanted to make the order of execution of the scripts in the early section more deterministic. In the course of debugging the ordering problems I noticed that moving the BEFOREs to REQUIREs prevented the changes in order from the first pass to the second pass without having to make any substantial changes. (Of course it's no secret that I think BEFORE should be avoided as much as possible, but this is a good example of why.) Reviewed by: silence on freebsd-rc@ MFC after: 8.1-RELEASE Revision Changes Path 1.9 +1 -1 src/etc/rc.d/SERVERS 1.2 +1 -1 src/etc/rc.d/ddb 1.13 +2 -1 src/etc/rc.d/dumpon 1.13 +1 -1 src/etc/rc.d/hostid 1.2 +0 -1 src/etc/rc.d/hostid_save 1.9 +1 -0 src/etc/rc.d/initrandom 1.7 +1 -2 src/etc/rc.d/mdconfig 1.19 +1 -1 src/etc/rc.d/mountcritlocal 1.18 +1 -2 src/etc/rc.d/savecore 1.23 +0 -2 src/etc/rc.d/sysctl 1.2 +0 -1 src/etc/rc.d/zvol