Date: Sun, 15 Jan 2006 21:18:00 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Rong-En Fan <grafan@gmail.com>, current@freebsd.org Subject: Re: [PATCH] Fix off-by-one bug in ifconfig's af_link.c Message-ID: <20060115191800.GH4687@ip.net.ua> In-Reply-To: <20060115182941.GA1182@galgenberg.net> References: <6eb82e0601140926n3d86e146m99aa9f47569b24aa@mail.gmail.com> <20060114182410.GA1108@galgenberg.net> <20060115182941.GA1182@galgenberg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--82evfD9Ogz2JrdWZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 15, 2006 at 07:29:41PM +0100, Ulrich Spoerlein wrote: > Ulrich Sp?rlein wrote: > > I'm pretty sure it's the link_getaddr in af_link.c, there are two > > possible fixes, depending on the requirements of link_addr() > >=20 > > If link_addr *needs* a terminating '\0', then we need to > > malloc(strlen(addr) + 2), if it doesn't need the terminating zero, we > > should get away with strncpy(temp + 1, addr, strlen(addr)) >=20 > Yeah, seems to be a slow sunday today. Attached is the fix for this > off-by-one bug. >=20 Committed, thanks! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --82evfD9Ogz2JrdWZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD4DBQFDyp/oqRfpzJluFF4RAvyQAJjfamxBfFbJNWud1RDVFEwn0jgzAJ9uJPbf RkBLiYF1bGExKZvn49bNCg== =M4wW -----END PGP SIGNATURE----- --82evfD9Ogz2JrdWZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060115191800.GH4687>