From owner-freebsd-current@FreeBSD.ORG Sun Jan 15 19:23:56 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BFA016A41F for ; Sun, 15 Jan 2006 19:23:56 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 492FD43D45 for ; Sun, 15 Jan 2006 19:23:53 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k0FJNq4x078103; Sun, 15 Jan 2006 21:23:52 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ip.net.ua [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 36276-02; Sun, 15 Jan 2006 21:23:23 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k0FJHvmT077996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 15 Jan 2006 21:17:57 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id k0FJI1nF091215; Sun, 15 Jan 2006 21:18:01 +0200 (EET) (envelope-from ru) Date: Sun, 15 Jan 2006 21:18:00 +0200 From: Ruslan Ermilov To: Rong-En Fan , current@freebsd.org Message-ID: <20060115191800.GH4687@ip.net.ua> References: <6eb82e0601140926n3d86e146m99aa9f47569b24aa@mail.gmail.com> <20060114182410.GA1108@galgenberg.net> <20060115182941.GA1182@galgenberg.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82evfD9Ogz2JrdWZ" Content-Disposition: inline In-Reply-To: <20060115182941.GA1182@galgenberg.net> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: Subject: Re: [PATCH] Fix off-by-one bug in ifconfig's af_link.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2006 19:23:56 -0000 --82evfD9Ogz2JrdWZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 15, 2006 at 07:29:41PM +0100, Ulrich Spoerlein wrote: > Ulrich Sp?rlein wrote: > > I'm pretty sure it's the link_getaddr in af_link.c, there are two > > possible fixes, depending on the requirements of link_addr() > >=20 > > If link_addr *needs* a terminating '\0', then we need to > > malloc(strlen(addr) + 2), if it doesn't need the terminating zero, we > > should get away with strncpy(temp + 1, addr, strlen(addr)) >=20 > Yeah, seems to be a slow sunday today. Attached is the fix for this > off-by-one bug. >=20 Committed, thanks! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --82evfD9Ogz2JrdWZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD4DBQFDyp/oqRfpzJluFF4RAvyQAJjfamxBfFbJNWud1RDVFEwn0jgzAJ9uJPbf RkBLiYF1bGExKZvn49bNCg== =M4wW -----END PGP SIGNATURE----- --82evfD9Ogz2JrdWZ--