From owner-cvs-usrsbin  Sat Mar  8 07:39:07 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id HAA18556
          for cvs-usrsbin-outgoing; Sat, 8 Mar 1997 07:39:07 -0800 (PST)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA18551;
          Sat, 8 Mar 1997 07:38:58 -0800 (PST)
Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id PAA12796;
	Sat, 8 Mar 1997 15:31:57 GMT
Message-Id: <199703081531.PAA12796@awfulhak.demon.co.uk>
X-Mailer: exmh version 1.6.9 8/22/96
To: "Andrey A. Chernov" <ache@freebsd.org>
cc: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-usrsbin@freebsd.org
Subject: Re: cvs commit: src/usr.sbin/ppp timer.c 
In-reply-to: Your message of "Sat, 08 Mar 1997 01:55:44 PST."
             <199703080955.BAA03844@freefall.freebsd.org> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 08 Mar 1997 15:31:57 +0000
From: Brian Somers <brian@awfulhak.demon.co.uk>
Sender: owner-cvs-usrsbin@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

> ache        97/03/08 01:55:43
> 
>   Modified:    usr.sbin/ppp  timer.c
>   Log:
>   Don't pend SIGALRM (Timer Service) due to
>   1) When carrier dropped, old variant often forget to detect it cause
>   unkillable loop forever (because SIGTERM pended too, but it will be
>   separate commit)
>   2) Time intervals accuracy reasons
>   
>   Should go into 2.2
>   
>   Revision  Changes    Path
>   1.11      +3 -3      src/usr.sbin/ppp/timer.c
> 

The only time the code can "forget" to pend a signal is if it gets caused
during the call to pending_signal() (between the signal() call and the
caused &= bit).

This change is going to re-invent the recursive malloc() problem (or
am I missing something?).

-- 
Brian <brian@awfulhak.demon.co.uk>, <brian@freebsd.org>
      <http://www.awfulhak.demon.co.uk/>
Don't _EVER_ lose your sense of humour....