Date: Thu, 16 Feb 2012 22:40:36 +0000 From: Chris Rees <crees@freebsd.org> To: Guido Falsi <mad@madpilot.net> Cc: gnome@freebsd.org, FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: PR ports/164449: update to finance/gnucash timeout Message-ID: <CADLo838_q3KsYRHRoHnhE2Ufs1VqwGrCyuX03eoSM0nMjnoTKQ@mail.gmail.com> In-Reply-To: <4F3D827E.6070000@madpilot.net> References: <20120213161546.GA95360@megatron.madpilot.net> <CADLo83_JoL_omcVyhAzrECL5OUyE9%2B-r49s24-eAwmqS08wppw@mail.gmail.com> <4F3D827E.6070000@madpilot.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 February 2012 22:26, Guido Falsi <mad@madpilot.net> wrote: > On 02/16/12 10:15, Chris Rees wrote: >> >> On 13 February 2012 16:15, Guido Falsi<mad@madpilot.net> =A0wrote: >>> >>> Hello, >>> >>> I'd like to ask if the PR in the subject can be committed due to >>> maintainer timeout. >> >> >> Teams don't time out as such usually... I've CC'd gnome@ as a gentle pok= e. > > > Thanks. I did not really know this. I'll remember this in the future. > >> >> Your patch also uses the incorrect test "$var" =3D=3D "value"; you shoul= d >> only use one =3D sign with test. =A0This will fail on 7.x. >> > > Really sorry about this one. It just slipped in. > > But...This did not fail on redports 7.x tinderbox: > > https://redports.org/~madpilot/20120124141905-52190-7485/gnucash-2.4.9.lo= g > > I would have checked this if it did. > > Anyway I'll remember to pay more attention in the future. Don't worry, I'll take a look at it and see if I can nag gnome@ directly :) Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838_q3KsYRHRoHnhE2Ufs1VqwGrCyuX03eoSM0nMjnoTKQ>