From owner-freebsd-ports@FreeBSD.ORG Thu Jul 8 22:12:42 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B11E1065673 for ; Thu, 8 Jul 2010 22:12:42 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 0B20D8FC1D for ; Thu, 8 Jul 2010 22:12:41 +0000 (UTC) Received: (qmail 14584 invoked by uid 399); 8 Jul 2010 22:12:41 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 8 Jul 2010 22:12:41 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Date: Thu, 8 Jul 2010 15:12:39 -0700 (PDT) From: Doug Barton To: John Baldwin In-Reply-To: <201007081750.00871.jhb@freebsd.org> Message-ID: References: <201007081750.00871.jhb@freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! OpenPGP: id=1A1ABC84 Organization: http://SupersetSolutions.com/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: ports@freebsd.org Subject: Re: Review request for new port: sysutils/etcupdate X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2010 22:12:42 -0000 On Thu, 8 Jul 2010, John Baldwin wrote: > This is a port for yet-another-/etc-merging tool that I wrote recently. It > passes portlint -N with one bogus warning because /etc is in the comment. I didn't try installing/deinstalling but you seem to have the right stuff in the Makefile for that. Overall it looks good, just a couple comments: 1. I don't think textproc is right for CATEGORIES, although sysutils is of course. 2. I don't think the do-fetch target is necessary, but if it is needed when you test it that's fine. 3. You have a pkg-descr~ file in the shar that should be deleted before you commit it. Assuming it passes all the tests in the porter's handbook for install, deinstall, package, etc. I'd say go ahead. :) Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso