From nobody Mon Aug 11 14:14:13 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c0xTK5gLgz64C4L; Mon, 11 Aug 2025 14:14:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c0xTK52T9z3Yjf; Mon, 11 Aug 2025 14:14:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754921653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0MYiyNTT00R5IgBzG5fg5sl+h+kvNYhljuUh2WhLQPA=; b=Zt9YOUBVs3jx2wx733EMUa5pl+9dD0gMinrFcYQCCpUXqqXzweYX8Dr3KNs7EqkQi0urEd hx3F7lX1D4U+9AhyeXmoZ/bRaofW59pDICvA7yRERbJDvIjgizKrm5o4CT7Zm8pERopwne jP6P37CTnUKwLhBlZ1JPSPUoi2DiJyRnTiUwJteo6sxY8EJz9GYULydO/pC0s6dNeRaPCr HamiyMqn6ZLJozE7fXRceh9MTTZkYcBlWZq9vOiDQr7oPqmgOne3GLtG4Eu/jJ6M1uhyxi z9J229XZvcCok83GQ1aszJSRY4CpvjS9qIip1wnJQEbPOj3Ms95C/M95uV9OsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754921653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0MYiyNTT00R5IgBzG5fg5sl+h+kvNYhljuUh2WhLQPA=; b=s/HBkPVabimdRJjfIhoa0PxY8Fo6PdCdpapw2hKqjduLW8k/nwmF8WVCIVXTWrZbKSP1d0 xJ8xN/FHhZoBywc1QSffxiC8vJvG4jOnxms1Iw7MxGFvUexoH7uA/S5R+XoN2H7RAZ96FO AyJC9lsvnOPmmjhlywkxZSozT84lH8+jEm5tvvqVA4N/v7QAhH7HnY2OoJr7kTFFrftwlv 65JbpOMXjJNVsaCA9rrVZvjbn4rlmYp417xLT3qEFdZ6KgsmxsiZ/yMBVtR5edSXjGrtzb mGq7XSeGoodaxJj7mRQjA6pwqXbDygvLJbltc49K/43Y/X3xg53jAi3E7iW14g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754921653; a=rsa-sha256; cv=none; b=wwcXLy2EJHrvGgJF92QnZ+05OO/ooFnxsy5Zz9GKgh5T10M4aEz76Rh+O0nEHmPVhmiAQG ioCOP6PNWAU1cfkLgsZiS4LKVCLVLtd1oiHal71QEfa24gkXZ6Yp19Jep2/PN9uU0eNYqU EysEPX+M3FRWiGDlOxftL1nHSENjAy3tXzVM2nqpHuTBDGL80oCviBNsuvkpOC/RnHAjf6 kNgiiVQn4Kw8W8kBGPljfkGCLGNAUqpEu7Frt+PSMK1IRrkMPPwCCgl+uN65AtGiGRq0L7 USrUIOEYM1YwZ2LN86K4mCRUQb2W3K0cDy3ne7y6NfapGyVCVBJKF8WgL4QX+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c0xTK4dBkzw0p; Mon, 11 Aug 2025 14:14:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57BEEDVA027941; Mon, 11 Aug 2025 14:14:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57BEEDXg027938; Mon, 11 Aug 2025 14:14:13 GMT (envelope-from git) Date: Mon, 11 Aug 2025 14:14:13 GMT Message-Id: <202508111414.57BEEDXg027938@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mariusz Zaborski Subject: git: a3eab0130488 - main - lsvfs(1): Make slight refactor List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: oshogbo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a3eab01304884e13342bdaca4cf5204fa97ba456 Auto-Submitted: auto-generated The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=a3eab01304884e13342bdaca4cf5204fa97ba456 commit a3eab01304884e13342bdaca4cf5204fa97ba456 Author: Faraz Vahedi AuthorDate: 2024-10-27 12:01:39 +0000 Commit: Mariusz Zaborski CommitDate: 2025-08-11 14:13:40 +0000 lsvfs(1): Make slight refactor Signed-off-by: Faraz Vahedi Reviewed by: markj, asomers (both earlier version) Pull Request: https://github.com/freebsd/freebsd-src/pull/1498 --- usr.bin/lsvfs/lsvfs.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/usr.bin/lsvfs/lsvfs.c b/usr.bin/lsvfs/lsvfs.c index 04ed38e8d978..5477d96434ac 100644 --- a/usr.bin/lsvfs/lsvfs.c +++ b/usr.bin/lsvfs/lsvfs.c @@ -39,8 +39,8 @@ int main(int argc, char **argv) { struct xvfsconf vfc, *xvfsp; - size_t buflen; - int cnt, i, rv = 0; + size_t cnt, buflen; + int rv = 0; argc--, argv++; @@ -59,15 +59,14 @@ main(int argc, char **argv) } } else { if (sysctlbyname("vfs.conflist", NULL, &buflen, NULL, 0) < 0) - err(1, "sysctl(vfs.conflist)"); - xvfsp = malloc(buflen); - if (xvfsp == NULL) - errx(1, "malloc failed"); + err(EXIT_FAILURE, "sysctl(vfs.conflist)"); + if ((xvfsp = malloc(buflen)) == NULL) + errx(EXIT_FAILURE, "malloc failed"); if (sysctlbyname("vfs.conflist", xvfsp, &buflen, NULL, 0) < 0) - err(1, "sysctl(vfs.conflist)"); + err(EXIT_FAILURE, "sysctl(vfs.conflist)"); cnt = buflen / sizeof(struct xvfsconf); - for (i = 0; i < cnt; i++) { + for (size_t i = 0; i < cnt; i++) { printf(FMT, xvfsp[i].vfc_name, xvfsp[i].vfc_typenum, xvfsp[i].vfc_refcount, fmt_flags(xvfsp[i].vfc_flags)); @@ -82,10 +81,9 @@ static const char * fmt_flags(int flags) { static char buf[sizeof(struct flaglist) * sizeof(fl)]; - int i; buf[0] = '\0'; - for (i = 0; i < (int)nitems(fl); i++) { + for (size_t i = 0; i < (int)nitems(fl); i++) { if ((flags & fl[i].flag) != 0) { strlcat(buf, fl[i].str, sizeof(buf)); strlcat(buf, ", ", sizeof(buf));