From owner-freebsd-current  Sun Jan 19 14:42:45 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E175B37B401
	for <current@freebsd.org>; Sun, 19 Jan 2003 14:42:44 -0800 (PST)
Received: from mail.evip.pl (mail.evip.com.pl [212.244.157.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D600B43E4A
	for <current@freebsd.org>; Sun, 19 Jan 2003 14:42:43 -0800 (PST)
	(envelope-from w@evip.pl)
Received: from w by mail.evip.pl with local (Exim 4.10)
	id 18aO9n-000OQx-00
	for current@freebsd.org; Sun, 19 Jan 2003 23:43:11 +0100
Date: Sun, 19 Jan 2003 23:43:11 +0100
From: Wiktor Niesiobedzki <w@evip.pl>
To: current@freebsd.org
Subject: Dummynet messages
Message-ID: <20030119224311.GB89748@mail.evip.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Hi,

sys/netinet/ip_dummynet.c:
975:   if (q->avg >= fs->max_th) { /* average queue >=  max threshold */
(...)
984:        } else {
985:            q->count = -1;
986:           printf("- drop");
987:        return 1 ;
989:        }

is quite meaningless. Shouldn't be it at least DEB(printf("- drop")? Or 
better "drop - max_th exceeded"?

Just a small proposition, I was quite confused, when I saw this message.

Best regards,

Wiktor Niesiobedzki

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message