Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 May 2020 03:21:43 +0000 (UTC)
From:      Cy Schubert <cy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r360591 - in stable: 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet
Message-ID:  <202005030321.0433Lhw1016598@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cy
Date: Sun May  3 03:21:42 2020
New Revision: 360591
URL: https://svnweb.freebsd.org/changeset/base/360591

Log:
  MFC r360100:
  
  fib4_free_nh_ext is an empty function. It does nothing. Don't call it.

Modified:
  stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c
Directory Properties:
  stable/11/   (props changed)

Changes in other areas also in this revision:
Modified:
  stable/12/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c
==============================================================================
--- stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c	Sun May  3 03:09:35 2020	(r360590)
+++ stable/11/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c	Sun May  3 03:21:42 2020	(r360591)
@@ -706,7 +706,6 @@ ipf_fastroute(m0, mpp, fin, fdp)
 	struct ifnet *ifp, *sifp;
 	struct sockaddr_in dst;
 	struct nhop4_extended nh4;
-	int has_nhop = 0;
 	u_long fibnum = 0;
 	u_short ip_off;
 	frdest_t node;
@@ -789,7 +788,6 @@ ipf_fastroute(m0, mpp, fin, fdp)
 		goto bad;
 	}
 
-	has_nhop = 1;
 	if (ifp == NULL)
 		ifp = nh4.nh_ifp;
 	if (nh4.nh_flags & NHF_GATEWAY)
@@ -932,9 +930,6 @@ done:
 		V_ipfmain.ipf_frouteok[0]++;
 	else
 		V_ipfmain.ipf_frouteok[1]++;
-
-	if (has_nhop)
-		fib4_free_nh_ext(fibnum, &nh4);
 
 	return 0;
 bad:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005030321.0433Lhw1016598>