From owner-freebsd-current@FreeBSD.ORG Tue Sep 5 21:31:35 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B535216A4DF for ; Tue, 5 Sep 2006 21:31:35 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37B5843D49 for ; Tue, 5 Sep 2006 21:31:34 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 36190 invoked from network); 5 Sep 2006 21:16:42 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 5 Sep 2006 21:16:42 -0000 Message-ID: <44FDECB6.2040304@freebsd.org> Date: Tue, 05 Sep 2006 23:31:34 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Jack Vogel References: <2a41acea0609011551v40338539u4eef48d091dd12ab@mail.gmail.com> <44F9384C.9070902@freebsd.org> <2a41acea0609021741y481a04c0r42902166eaba78d7@mail.gmail.com> <20060905162542.GA63869@hub.freebsd.org> <44FDAF08.20407@freebsd.org> <20060905182313.GA85389@hub.freebsd.org> <44FDD65C.6070109@freebsd.org> <2a41acea0609051410i7d968b88ocf240514ff410452@mail.gmail.com> In-Reply-To: <2a41acea0609051410i7d968b88ocf240514ff410452@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net , freebsd-current , Prafulla Deuskar Subject: Re: RFC: TSO patch for current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2006 21:31:35 -0000 Jack Vogel wrote: > On 9/5/06, Andre Oppermann wrote: >> Prafulla Deuskar wrote: >> > Your patch looks good and is the way to go. >> > >> > So after Jack confirms that your patch works with the em driver >> > would you commit to to -current? >> >> Absolutely. :-) >> >> > The driver related changes can follow.. >> > >> > Later we also need to fix ifconfig so that user can enable/disable >> TSO on the interface. >> >> I'll do that together with the TSO code. > > OK, I've built and done some touch testing of this. I like it, the > driver has > some counters of the number of TSO bursts it does, and I think I see more > per netperf test with your patch than mine. > > Hard to do real performance testing with all that WITNESS stuff in, but > I will be making a 6.1 version of your patch to test with since I have my > driver running on that anyway. You can disable WITNESS and INVARIANTS pretty easily in -current and get the full performance with it. > If you do the ifconfig changes there will need to be a small amount of > code added to em_ioctl() but it should be trivial. > > You want me to reissue a driver patch with changes for your code? Yes, please do so. I've got a dual-em card which I can test with myself. -- Andre